Fix DryRun not loading deployment state from storage for hash comparison#476
Open
pardhasaradhireddy wants to merge 1 commit intoAzure-Player:masterfrom
Open
Fix DryRun not loading deployment state from storage for hash comparison#476pardhasaradhireddy wants to merge 1 commit intoAzure-Player:masterfrom
pardhasaradhireddy wants to merge 1 commit intoAzure-Player:masterfrom
Conversation
When running Publish-AdfV2FromJson with -DryRun flag, the deployment state was not being loaded from Azure Storage, causing the hash comparison to run against an empty state. This resulted in all objects being marked as changed instead of only showing actual changes. The Get-StateFromStorage call was inside the (!$DryRun.IsPresent) block, which skipped loading the state during dry runs. Moved the state loading outside this block so it executes for both DryRun and normal deployments. This is a read-only operation and safe for DryRun mode. The Set-StateToStorage (write operation) still only executes after actual deployment, not during DryRun. Fixes: DryRun showing all objects as changed when incremental deployment is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Publish-AdfV2FromJson with -DryRun flag, the deployment state was not being loaded from Azure Storage, causing the hash comparison to run against an empty state. This resulted in all objects being marked as changed instead of only showing actual changes.
The Get-StateFromStorage call was inside the (!$DryRun.IsPresent) block, which skipped loading the state during dry runs. Moved the state loading outside this block so it executes for both DryRun and normal deployments.
This is a read-only operation and safe for DryRun mode. The Set-StateToStorage (write operation) still only executes after actual deployment, not during DryRun.
Fixes: DryRun showing all objects as changed when incremental deployment is enabled