Skip to content

Fix DryRun not loading deployment state from storage for hash comparison #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pardhasaradhireddy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix DryRun not loading deployment state from storage for hash comparison #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions public/Publish-AdfV2FromJson.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,6 @@ function Publish-AdfV2FromJson {
$targetAdf = Get-AzDataFactoryV2 -ResourceGroupName "$ResourceGroupName" -Name "$DataFactoryName" -ErrorAction:Ignore
if ($targetAdf) {
Write-Host "Azure Data Factory exists."
if ($opt.IncrementalDeployment -and !$DryRun.IsPresent) {
Write-Host "Loading Deployment State from Storage..."
$ds = Get-StateFromStorage -DataFactoryName $DataFactoryName -LocationUri $opt.IncrementalDeploymentStorageUri
}
}
else {
$msg = "Azure Data Factory instance does not exist."
Expand All @@ -175,13 +171,19 @@ function Publish-AdfV2FromJson {

if ($null -eq $targetAdf) {
Write-Host "ADFT0032: The process is exiting the function. Do fix the issue and run again."
return
return
}
}
else {
Write-Host "DRY RUN: Skipping ADF existence verification..."
}

# Load deployment state from storage for incremental deployment (needed for both DryRun and actual deployment)
if ($opt.IncrementalDeployment) {
Write-Host "Loading Deployment State from Storage..."
$ds = Get-StateFromStorage -DataFactoryName $DataFactoryName -LocationUri $opt.IncrementalDeploymentStorageUri
}

Write-Host "===================================================================================";
Write-Host "STEP: Reading Azure Data Factory from JSON files..."
$adf = Import-AdfFromFolder -FactoryName $DataFactoryName -RootFolder "$RootFolder"
Expand Down