Skip to content

Conversation

john-carroll-sw
Copy link
Contributor

@john-carroll-sw john-carroll-sw commented Sep 16, 2024

Purpose

I was following the instructions to add in the 'Upload Documents' feature to this demo. I ran into a few issues when running the scripts.

Does this introduce a breaking change?

The changes are minor. But they should be reviewed on your end. It's not much, but it's what I needed to get things rolling past errors.

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

…nge from -n to -z ensures that the script correctly verifies whether the AZURE_ADLS_GEN2_STORAGE_ACCOUNT environment variable is set and non-empty before proceeding. This is the intended behavior to avoid running the script without the necessary configuration.
@john-carroll-sw
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@pamelafox
Copy link
Collaborator

@mattgotteiner These are changes that @john-carroll-sw had to make to get the ADLS2 import working for his sample. Not sure whether they are generic to all tenants or if we need some flexibility.

Copy link
Contributor Author

@john-carroll-sw john-carroll-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattgotteiner @pamelafox does this change look good?

@pamelafox pamelafox merged commit 8f3abc4 into Azure-Samples:main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants