Skip to content

Adlsgen2 fixes #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Adlsgen2 fixes #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1fdc9b
Modified create_or_get_group Function. Added the mailEnabled and mail…
john-carroll-sw Sep 16, 2024
d7a93c6
Changed the conditional check in the adlsgen2setup.sh script. The ch…
john-carroll-sw Sep 16, 2024
86c592e
Added a comment to inform the developer to resolve a potential AAD te…
john-carroll-sw Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/adlsgen2setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,11 @@ async def create_or_get_group(self, group_name: str):
logging.info(f"Could not find group {group_name}, creating...")
group = {
"displayName": group_name,
"groupTypes": ["Unified"],
"securityEnabled": self.security_enabled_groups,
"groupTypes": ["Unified"],
# If Unified does not work for you, then you may need the following settings instead:
# "mailEnabled": False,
# "mailNickname": group_name,
}
async with session.post("https://graph.microsoft.com/v1.0/groups", json=group) as response:
content = await response.json()
Expand Down
2 changes: 1 addition & 1 deletion scripts/adlsgen2setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

. ./scripts/loadenv.sh

if [ -n "$AZURE_ADLS_GEN2_STORAGE_ACCOUNT" ]; then
if [ -z "$AZURE_ADLS_GEN2_STORAGE_ACCOUNT" ]; then
echo 'AZURE_ADLS_GEN2_STORAGE_ACCOUNT must be set to continue'
exit 1
fi
Expand Down