Skip to content

Port Python tests workflow to uv #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Port Python tests workflow to uv #2129

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa515d4
Clean up tasks
pamelafox Nov 7, 2024
0e6a9c4
Update precommit and run on files
pamelafox Nov 7, 2024
e739ef8
Use uv for workflow
pamelafox Nov 7, 2024
5b2306d
Merge branch 'main' into uvpip
pamelafox Nov 7, 2024
bc6b4ba
Merge branch 'main' into uvpip
pamelafox Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/python-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,21 @@ jobs:
matrix:
os: ["ubuntu-20.04", "windows-latest"]
python_version: ["3.9", "3.10", "3.11", "3.12"]
env:
UV_SYSTEM_PYTHON: 1
steps:
- uses: actions/checkout@v4
- name: Setup python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python_version }}
architecture: x64
- name: Install uv
uses: astral-sh/setup-uv@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool - where can I learn more about UV?

Copy link
Collaborator Author

@pamelafox pamelafox Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my former colleague Charlie Marsh who started it all!
https://talkpython.fm/episodes/show/476/unified-python-packaging-with-uv
Or just the docs:
https://github.com/astral-sh/uv

with:
enable-cache: true
version: "0.4.20"
cache-dependency-glob: "requirements**.txt"
- name: Setup node
uses: actions/setup-node@v4
with:
Expand All @@ -44,8 +52,7 @@ jobs:
npm run build
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements-dev.txt
uv pip install -r requirements-dev.txt
- name: Lint with ruff
run: ruff check .
- name: Check types with mypy
Expand Down
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
exclude: '^tests/snapshots/'
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v5.0.0
hooks:
- id: check-yaml
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.14
rev: v0.7.2
hooks:
- id: ruff
- repo: https://github.com/psf/black
rev: 24.1.0
rev: 24.10.0
hooks:
- id: black
- repo: https://github.com/pre-commit/mirrors-prettier
Expand Down
15 changes: 0 additions & 15 deletions .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
"tasks": [
{
"label": "Start App",
"type": "dotenv",
"targetTasks": [
"Start App (Script)"
],
"file": "${input:dotEnvFilePath}"
},
{
"label": "Start App (Script)",
"type": "shell",
"command": "${workspaceFolder}/app/start.sh",
"windows": {
Expand All @@ -24,12 +16,5 @@
},
"problemMatcher": []
}
],
"inputs": [
{
"id": "dotEnvFilePath",
"type": "command",
"command": "azure-dev.commands.getDotEnvFilePath"
}
]
}
2 changes: 1 addition & 1 deletion app/frontend/src/assets/github.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/frontend/src/assets/search.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/frontend/src/locales/da/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,4 +134,4 @@
"useOidSecurityFilter": "Filtrér søgeresultater baseret på den godkendte brugers OID.",
"useGroupsSecurityFilter": "Filtrér søgeresultater baseret på den godkendte brugers adgangsgrupper."
}
}
}
4 changes: 2 additions & 2 deletions app/frontend/src/locales/nl/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"minimumSearchScore": "Minimale zoekscore",
"minimumRerankerScore": "Minimale reranker score",
"retrieveCount": "Dit aantal zoekresultaten ophalen:",
"includeCategory": "Categorie opnemen",
"includeCategory": "Categorie opnemen",
"includeCategoryOptions": {
"all": "Alle"
},
Expand Down Expand Up @@ -151,4 +151,4 @@
"useOidSecurityFilter": "Filtert zoekresultaten op basis van de OID van de geauthenticeerde gebruiker.",
"useGroupsSecurityFilter": "Filtert zoekresultaten op basis van de groepen van de geauthenticeerde gebruiker."
}
}
}