Resolve issues with colliding private endpoint names, and redundant private endpoints

[kachihro]

Purpose

When deploying Private EndPoints for AppService, there was a set of errors with DUPLICATE identifiers. The changes in this PR have fixed this.

Also fixes #2742, where the OpenAI resource was included in multiple endpoints.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ X ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ X ] No

Type of change

[ X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

• The current tests all pass (python -m pytest).
• [ X ] I added tests that prove my fix is effective or that my feature works
• I ran python -m pytest --cov to verify 100% coverage of added lines
• I ran python -m mypy to check for type errors
• I either used the pre-commit hooks or ran ruff and black manually on my code.

[Copilot]

Pull Request Overview

This PR fixes deployment issues with private endpoints in Azure infrastructure templates by resolving duplicate identifier conflicts that were causing deployment failures.

• Adds index-based naming to private endpoint modules to prevent duplicate names
• Updates DNS zone configuration naming to use unique identifiers
• Adds whitespace formatting for code clarity

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
infra/private-endpoints.bicep	Adds index parameter to module loop and incorporates it into the module name
infra/core/networking/private-endpoint.bicep	Updates DNS zone config name to include unique identifiers

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[pamelafox]

@kachihro Thanks, this looks reasonable! I'll verify on my private endpoint deployment before merging.

[pamelafox]

@kachihro I tested locally and found an unrelated issue with OpenAI private endpoint, so I pushed that fix to this branch. I'll merge once CI passes. Thanks!