-
Notifications
You must be signed in to change notification settings - Fork 17
Generate a GitHub Action Workflow through VSCode Extension #79
base: feature/cicd
Are you sure you want to change the base?
Conversation
Tatsinnit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡☕️ Thanks for adding me to this review, really appreciate it, I have few notices, observation and comments below. Thank you so much.
| @@ -0,0 +1,371 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡☕️ Note\Question for archival reason: we borrowed the whole interface from : https://github.com/microsoft/vscode/tree/main/extensions/git , is there any way else we would have used this? or we have to duplicate this interface? Thanks heaps.
We should also document all this borrowed code between codebases please. It will help in maintenance and the historic reasons for anyone else scouting the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required to be copied from the repository and this comment contains its location. I also believe its common knowledge in VS Code Extension development that these file must be copied to use the interface they offer, unless offered within a package manager.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
This adds the features of creating a github actions workflow through the vscode extension.
Add new dependency on git extension within vscode.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: