Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Dec 6, 2022

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

This adds the features of creating a github actions workflow through the vscode extension.

Add new dependency on git extension within vscode.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Testing extension working through properly configured Azure resources.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 changed the title Initial UI + AKS Cluster Support Generate a GitHub Action Workflow through VSCode Extension Dec 7, 2022
@bfoley13 bfoley13 marked this pull request as ready for review December 14, 2022 15:10
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡☕️ Thanks for adding me to this review, really appreciate it, I have few notices, observation and comments below. Thank you so much.

@@ -0,0 +1,371 @@
/*---------------------------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡☕️ Note\Question for archival reason: we borrowed the whole interface from : https://github.com/microsoft/vscode/tree/main/extensions/git , is there any way else we would have used this? or we have to duplicate this interface? Thanks heaps.

We should also document all this borrowed code between codebases please. It will help in maintenance and the historic reasons for anyone else scouting the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required to be copied from the repository and this comment contains its location. I also believe its common knowledge in VS Code Extension development that these file must be copied to use the interface they offer, unless offered within a package manager.

@davidgamero davidgamero mentioned this pull request May 11, 2023
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants