Add scale_rule_name to container app jobs scale definition #8552
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @dofficewala, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Greedygre,
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
|
@microsoft-github-policy-service agree company="Microsoft" |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| ++++++ | ||
| * 'az containerapp create': support --kind {functionapp} | ||
|
|
||
| 1.1.0b4 |
There was a problem hiding this comment.
Please add your description to upcoming and don't change the version.
| # HISTORY.rst entry. | ||
|
|
||
| VERSION = '1.1.0b3' | ||
| VERSION = '1.1.0b4' |
There was a problem hiding this comment.
Please don't change the version in your PR.
| c.argument('min_executions', type=int, help="Minimum number of job executions to run per polling interval.") | ||
| c.argument('max_executions', type=int, help="Maximum number of job executions to run per polling interval.") | ||
| c.argument('polling_interval', type=int, help="Interval to check each event source in seconds. Defaults to 30s.") | ||
| c.argument('scale_rule_name', options_list=['--scale-rule-name', '--srn'], help="The name of the scale rule.") |
There was a problem hiding this comment.
You only add this new param in _params.py is not enough.
You need to update the function create_containerappsjob
Besides, please add test for the new params.
|
Hi @dofficewala |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.