-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add scale_rule_name to container app jobs scale definition #8552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -323,6 +323,7 @@ def load_arguments(self, _): | |
| c.argument('min_executions', type=int, help="Minimum number of job executions to run per polling interval.") | ||
| c.argument('max_executions', type=int, help="Maximum number of job executions to run per polling interval.") | ||
| c.argument('polling_interval', type=int, help="Interval to check each event source in seconds. Defaults to 30s.") | ||
| c.argument('scale_rule_name', options_list=['--scale-rule-name', '--srn'], help="The name of the scale rule.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You only add this new param in Besides, please add test for the new params. |
||
| c.argument('scale_rule_type', options_list=['--scale-rule-type', '--srt'], help="The type of the scale rule.") | ||
| c.argument('scale_rule_identity', options_list=['--scale-rule-identity', '--sri'], help='Resource ID of a managed identity to authenticate with Azure scaler resource(storage account/eventhub or else), or System to use a system-assigned identity.', is_preview=True) | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |
| # TODO: Confirm this is the right version number you want and it matches your | ||
| # HISTORY.rst entry. | ||
|
|
||
| VERSION = '1.1.0b3' | ||
| VERSION = '1.1.0b4' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please don't change the version in your PR. |
||
|
|
||
| # The full list of classifiers is available at | ||
| # https://pypi.python.org/pypi?%3Aaction=list_classifiers | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your description to
upcomingand don't change the version.