Skip to content

Conversation

@wchigit
Copy link
Contributor

@wchigit wchigit commented May 22, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az webapp/containerapp connection create postgres-flexible --user-identity client-id=XX subs-id=XX --source-id XX --target-id XX
az webapp/containerapp connection create postgres-flexible --system-identity -source-id XX --target-id XX

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 22, 2025 08:52
@azure-client-tools-bot-prd
Copy link

Hi @wchigit,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 22, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces deprecated ad-admin commands with the new microsoft-entra-admin subcommands for PostgreSQL passwordless connections.

  • Update list call to use microsoft-entra-admin instead of ad-admin
  • Update create call to use microsoft-entra-admin instead of ad-admin
Comments suppressed due to low confidence (1)

src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py:693

  • No tests currently validate that the new microsoft-entra-admin commands are invoked correctly. Add unit tests for set_user_admin to ensure the right CLI strings are constructed.
admins = run_cli_cmd('az postgres flexible-server microsoft-entra-admin list -g "{}" -s "{}" --subscription "{}"'.format(

@github-actions
Copy link

github-actions bot commented May 22, 2025

Hi @wchigit

Release Suggestions

Module: serviceconnector-passwordless

  • Update VERSION to 3.3.2 in src/serviceconnector-passwordless/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 22, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 22, 2025
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 22, 2025
@wchigit
Copy link
Contributor Author

wchigit commented May 22, 2025

@kairu-ms Could you take a look at this? Why am I having trouble updating the version? THX

@AllyW
Copy link
Contributor

AllyW commented May 23, 2025

@kairu-ms Could you take a look at this? Why am I having trouble updating the version? THX

@wchigit the issue comes from the unsuccessful release from last version 3.3.2: #8688

The latest official release version is still 3.3.1 https://github.com/Azure/azure-cli-extensions/releases?q=serviceconnector-&expanded=true therefore in this pr, it only allows 3.3.2.

@AllyW
Copy link
Contributor

AllyW commented May 23, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wchigit
Copy link
Contributor Author

wchigit commented May 23, 2025

@kairu-ms Could you take a look at this? Why am I having trouble updating the version? THX

@wchigit the issue comes from the unsuccessful release from last version 3.3.2: #8688

The latest official release version is still 3.3.1 https://github.com/Azure/azure-cli-extensions/releases?q=serviceconnector-&expanded=true therefore in this pr, it only allows 3.3.2.

Thanks for reply. The version should be updated to 3.3.2 in this PR: #8688. Was there a reason why this is not released? @AllyW

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 23, 2025
@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AllyW
Copy link
Contributor

AllyW commented May 23, 2025

@kairu-ms Could you take a look at this? Why am I having trouble updating the version? THX

@wchigit the issue comes from the unsuccessful release from last version 3.3.2: #8688
The latest official release version is still 3.3.1 https://github.com/Azure/azure-cli-extensions/releases?q=serviceconnector-&expanded=true therefore in this pr, it only allows 3.3.2.

Thanks for reply. The version should be updated to 3.3.2 in this PR: #8688. Was there a reason why this is not released? @AllyW

Pipeline got stuck by setuptools updates and pipeline didn't get triggered as expected. Confirm with @wangzelin007 in teams channel.

@wangzelin007
Copy link
Member

At that time, setuptools was upgrading and caused many of our CI failures. We were working on pinning the setuptools version, so I didn't notice that the release had failed.
I did receive the release failed Teams notification though.
image
image
image

@wangzelin007 wangzelin007 merged commit b8e0144 into Azure:main May 23, 2025
24 checks passed
bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
…g because of deprecated command (Azure#8782)

* update command

* update version

* update history

* fix comment

* update version

* use 3.3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants