-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Service Connector] Fix PostgreSQL passwordless connection not working because of deprecated command #8782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @wchigit, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces deprecated ad-admin commands with the new microsoft-entra-admin subcommands for PostgreSQL passwordless connections.
- Update
listcall to usemicrosoft-entra-admininstead ofad-admin - Update
createcall to usemicrosoft-entra-admininstead ofad-admin
Comments suppressed due to low confidence (1)
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py:693
- No tests currently validate that the new
microsoft-entra-admincommands are invoked correctly. Add unit tests forset_user_adminto ensure the right CLI strings are constructed.
admins = run_cli_cmd('az postgres flexible-server microsoft-entra-admin list -g "{}" -s "{}" --subscription "{}"'.format(
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
Show resolved
Hide resolved
|
Hi @wchigit Release SuggestionsModule: serviceconnector-passwordless
Notes
|
|
@kairu-ms Could you take a look at this? Why am I having trouble updating the version? THX |
@wchigit the issue comes from the unsuccessful release from last version The latest official release version is still |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Thanks for reply. The version should be updated to 3.3.2 in this PR: #8688. Was there a reason why this is not released? @AllyW |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Pipeline got stuck by setuptools updates and pipeline didn't get triggered as expected. Confirm with @wangzelin007 in teams channel. |
…g because of deprecated command (Azure#8782) * update command * update version * update history * fix comment * update version * use 3.3.2



This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az webapp/containerapp connection create postgres-flexible --user-identity client-id=XX subs-id=XX --source-id XX --target-id XX
az webapp/containerapp connection create postgres-flexible --system-identity -source-id XX --target-id XX
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.