Skip to content

[Service Connector] Fix PostgreSQL passwordless connection not working because of deprecated command #8782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangzelin007 merged 6 commits into from
May 23, 2025
Merged

[Service Connector] Fix PostgreSQL passwordless connection not working because of deprecated command #8782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8bd954
update command
wchigit May 22, 2025
1a51455
update version
wchigit May 22, 2025
32c9ed3
update history
wchigit May 22, 2025
9cbaf6e
fix comment
wchigit May 22, 2025
1a907c1
update version
wchigit May 22, 2025
c626b09
use 3.3.2
wchigit May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/serviceconnector-passwordless/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Release History
3.3.2
++++++
* Add documentation explaining manual steps required for connecting to SQL database in Fabric.
* Fix PostgreSQL flexible server connection not working due to deprecation of `ad-admin` command.

3.3.1
++++++
Expand Down
4 changes: 2 additions & 2 deletions src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ def enable_target_aad_auth(self):
self.target_id))

def set_user_admin(self, user_object_id, **kwargs):
admins = run_cli_cmd('az postgres flexible-server ad-admin list -g "{}" -s "{}" --subscription "{}"'.format(
admins = run_cli_cmd('az postgres flexible-server microsoft-entra-admin list -g "{}" -s "{}" --subscription "{}"'.format(
self.resource_group, self.db_server, self.subscription))

if not user_object_id:
Expand All @@ -706,7 +706,7 @@ def set_user_admin(self, user_object_id, **kwargs):
admin_info = next((ad for ad in admins if ad.get('objectId', "") == user_object_id), None)
if not admin_info:
logger.warning('Set current user as DB Server Microsoft Entra Administrators.')
admin_info = run_cli_cmd('az postgres flexible-server ad-admin create -u "{}" -i "{}" -g "{}" -s "{}" --subscription "{}" -t {}'.format(
admin_info = run_cli_cmd('az postgres flexible-server microsoft-entra-admin create -u "{}" -i "{}" -g "{}" -s "{}" --subscription "{}" -t {}'.format(
self.login_username, user_object_id, self.resource_group, self.db_server, self.subscription, self.login_usertype))
self.admin_username = admin_info.get('principalName', self.login_username)

Expand Down
Loading