Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @FumingZhang, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API version in multiple test recordings to fix failures caused by a previous change. Key changes include:
- Updating the api-version query parameter from "2022-09-01" to "2024-11-01" across all test recording YAML files.
- Ensuring consistency in the recorded service URIs for various resource group-related tests.
Reviewed Changes
Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_aks_create_acns_with_flow_logs.yaml | Updated api-version query parameter |
| test_aks_check_network.yaml | Updated api-version query parameter (GET and HEAD endpoints) |
| test_aks_availability_zones.yaml | Updated api-version query parameter for resource group GET request |
| test_aks_automatic_sku.yaml | Updated api-version query parameter for both GET and HEAD requests |
| test_aks_approuting_update_with_monitoring_addon_enabled.yaml | Updated api-version query parameter for GET and HEAD requests |
| test_aks_addon_update_with_confcom.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_update_with_azurekeyvaultsecretsprovider.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_update_all_disabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_show_openservicemesh_enabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_show_confcom_enabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_show_all_disabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_list_openservicemesh_enabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_list_confcom_enabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_list_all_disabled.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_enable_with_openservicemesh.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_enable_with_azurekeyvaultsecretsprovider.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_enable_confcom_addon.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_disable_openservicemesh.yaml | Updated api-version query parameter for GET request |
| test_aks_addon_disable_confcom_addon.yaml | Updated api-version query parameter for GET request |
| test_aks_abort.yaml | Updated api-version query parameter for GET request |
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
{AKS} Fix test recordings broken by Azure/azure-cli#31449
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.