-
Notifications
You must be signed in to change notification settings - Fork 1.5k
networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies. #8888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…kfabric api that caused failures - swagger discrepencies.
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| networkfabric taprule create | cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property aaz_type from float to int |
||
| networkfabric taprule create | cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property type from float to int |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the managednetworkfabric extension to align CLI and SDK models with the networkfabric API, fixing type discrepancies for polling intervals and adjusting the validate-configuration response schema.
- Bump extension version to 8.0.0b6
- Change
pollingIntervalInSecondsfrom float to integer in taprule commands and arguments - Refactor validate-configuration schema to nest fields under
propertiesand add error details; update HISTORY.rst accordingly
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/managednetworkfabric/setup.py | Bump version to 8.0.0b6 |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_wait.py | Change polling interval type from float to int |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_update.py | Change polling interval type from float to int |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_show.py | Change polling interval type from float to int |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_list.py | Change polling interval type from float to int |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py | Change polling interval argument and model from float to int |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py | Nest configuration_state and url under properties, add error |
| src/managednetworkfabric/HISTORY.rst | Add entries for 8.0.0b6 and 8.0.0b5; fix links |
Comments suppressed due to low confidence (3)
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py:211
- [nitpick] Consider adding
serialized_name="url"andflags={"read_only": True}toproperties.urlfor consistency with other schema properties.
properties.url = AAZStrType()
src/managednetworkfabric/HISTORY.rst:6
- The
8.0.0b6and8.0.0b5headers are missing underlines like other versions; add a line of dashes or equals under each heading for proper RST formatting.
8.0.0b6
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py:102
- Since
polling_interval_in_secondschanged from float to int, ensure unit or integration tests cover integer inputs and validate behavior for this argument.
_args_schema.polling_interval_in_seconds = AAZIntArg(
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_wait.py
Show resolved
Hide resolved
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| * Fixes 'taprule create' command as the API cannot support float values for 'polling-interval-in-seconds' option, i.e. - '30.0'. | ||
|
|
||
| 8.0.0b4 | ||
| ++++++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the above 2 versions missed ++++++; btw, can we combine them to 1 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have changed it.
|
could you plz provide the link of pull reuqest in Azure/aaz? |
|
[Release] Update index.json for extension [ managednetworkfabric-8.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128212645&view=results |
networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.