Skip to content

Conversation

@idanielsteven
Copy link
Contributor

@idanielsteven idanielsteven commented Jun 20, 2025

networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…kfabric api that caused failures - swagger discrepencies.
Copilot AI review requested due to automatic review settings June 20, 2025 21:52
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 20, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️managednetworkfabric
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property aaz_type from float to int
⚠️ 1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property type from float to int

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the managednetworkfabric extension to align CLI and SDK models with the networkfabric API, fixing type discrepancies for polling intervals and adjusting the validate-configuration response schema.

  • Bump extension version to 8.0.0b6
  • Change pollingIntervalInSeconds from float to integer in taprule commands and arguments
  • Refactor validate-configuration schema to nest fields under properties and add error details; update HISTORY.rst accordingly

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/managednetworkfabric/setup.py Bump version to 8.0.0b6
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_wait.py Change polling interval type from float to int
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_update.py Change polling interval type from float to int
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_show.py Change polling interval type from float to int
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_list.py Change polling interval type from float to int
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py Change polling interval argument and model from float to int
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py Nest configuration_state and url under properties, add error
src/managednetworkfabric/HISTORY.rst Add entries for 8.0.0b6 and 8.0.0b5; fix links
Comments suppressed due to low confidence (3)

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py:211

  • [nitpick] Consider adding serialized_name="url" and flags={"read_only": True} to properties.url for consistency with other schema properties.
            properties.url = AAZStrType()

src/managednetworkfabric/HISTORY.rst:6

  • The 8.0.0b6 and 8.0.0b5 headers are missing underlines like other versions; add a line of dashes or equals under each heading for proper RST formatting.
8.0.0b6

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py:102

  • Since polling_interval_in_seconds changed from float to int, ensure unit or integration tests cover integer inputs and validate behavior for this argument.
        _args_schema.polling_interval_in_seconds = AAZIntArg(

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@idanielsteven idanielsteven changed the title networkfabric - cli and sdk updates to fix issues found in the networ… networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies. Jun 20, 2025
@github-actions
Copy link

github-actions bot commented Jun 20, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 20, 2025
@yonzhan yonzhan requested review from kairu-ms and necusjz June 21, 2025 00:56
@yonzhan yonzhan requested a review from jsntcy June 21, 2025 00:57
* Fixes 'taprule create' command as the API cannot support float values for 'polling-interval-in-seconds' option, i.e. - '30.0'.

8.0.0b4
++++++
Copy link
Member

@necusjz necusjz Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above 2 versions missed ++++++; btw, can we combine them to 1 version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have changed it.

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 23, 2025
@necusjz
Copy link
Member

necusjz commented Jun 24, 2025

could you plz provide the link of pull reuqest in Azure/aaz?

@necusjz necusjz merged commit 11e52d6 into Azure:main Jun 24, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric-8.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128212645&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants