Skip to content

networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies. #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 4 commits into from
Jun 24, 2025
Merged

networkfabric - cli and sdk updates to fix issues found in the netwokfabric api that caused failures - swagger discrepancies. #8888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4258ef4
networkfabric - cli and sdk updates to fix issues found in the networ…
idanielsteven Jun 20, 2025
6af2d5f
updating history file
idanielsteven Jun 20, 2025
34e16dc
updating metadata file
idanielsteven Jun 20, 2025
adb1e1b
fixing history file from internal repo.
idanielsteven Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/managednetworkfabric/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

8.0.0b5
* Fixes 'taprule create' command as the API cannot support float values for 'polling-interval-in-seconds' option, i.e. - '30.0'.
* Fixes the response object model for validate-configuration operations that cause response of the operation to not show any output.
* az core cli updated to version 2.70, aaz_dev updated to version 4.2.0, and azdev to version 0.2.4.

8.0.0b4
++++++
Copy link
Member

@necusjz necusjz Jun 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above 2 versions missed ++++++; btw, can we combine them to 1 version?

Copy link
Contributor Author

@idanielsteven idanielsteven Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have changed it.

* Fixes 'device run-ro' command for missing fields in the response.
Expand All @@ -29,7 +34,7 @@ Release History

7.0.0
++++++
* This version requires a minimum of 2.66 Azure core CLI. See release notes for more details: https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/docs-ref-conceptual/Latest-version/release-notes-azure-cli.md
* This version requires a minimum of 2.66 Azure core CLI. See release notes for more details: https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/docs-ref-conceptual/release-notes-azure-cli.md
* This version upgrades the internal generation tool aaz-dev-tools to 3.1.0. Refer to the release notes for more details: https://github.com/Azure/aaz-dev-tools/releases/tag/v3.1.0.

6.4.0
Expand Down
13 changes: 9 additions & 4 deletions ...ric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,18 @@ def _build_schema_on_200(cls):
cls._schema_on_200 = AAZObjectType()

_schema_on_200 = cls._schema_on_200
_schema_on_200.configuration_state = AAZStrType(
_schema_on_200.error = AAZObjectType()
_ValidateConfigurationHelper._build_schema_error_detail_read(_schema_on_200.error)
_schema_on_200.properties = AAZObjectType(
flags={"read_only": True},
)

properties = cls._schema_on_200.properties
properties.configuration_state = AAZStrType(
serialized_name="configurationState",
flags={"read_only": True},
)
_schema_on_200.error = AAZObjectType()
_ValidateConfigurationHelper._build_schema_error_detail_read(_schema_on_200.error)
_schema_on_200.url = AAZStrType()
properties.url = AAZStrType()

return cls._schema_on_200

Expand Down
8 changes: 4 additions & 4 deletions ...nagednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ def _build_arguments_schema(cls, *args, **kwargs):
min_length=1,
),
)
_args_schema.polling_interval_in_seconds = AAZFloatArg(
_args_schema.polling_interval_in_seconds = AAZIntArg(
options=["--polling-interval-in-seconds"],
arg_group="Properties",
help="Polling interval in seconds.",
default=30.0,
default=30,
enum={"120": 120, "30": 30, "60": 60, "90": 90},
)
_args_schema.tap_rules_url = AAZStrArg(
Expand Down Expand Up @@ -534,7 +534,7 @@ def content(self):
properties.set_prop("dynamicMatchConfigurations", AAZListType, ".dynamic_match_configurations")
properties.set_prop("globalNetworkTapRuleActions", AAZObjectType, ".global_network_tap_rule_actions")
properties.set_prop("matchConfigurations", AAZListType, ".match_configurations")
properties.set_prop("pollingIntervalInSeconds", AAZFloatType, ".polling_interval_in_seconds")
properties.set_prop("pollingIntervalInSeconds", AAZIntType, ".polling_interval_in_seconds")
properties.set_prop("tapRulesUrl", AAZStrType, ".tap_rules_url")

dynamic_match_configurations = _builder.get(".properties.dynamicMatchConfigurations")
Expand Down Expand Up @@ -760,7 +760,7 @@ def _build_schema_on_200_201(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down
4 changes: 2 additions & 2 deletions ...managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def _build_schema_on_200(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down Expand Up @@ -567,7 +567,7 @@ def _build_schema_on_200(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down
2 changes: 1 addition & 1 deletion ...managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def _build_schema_on_200(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down
2 changes: 1 addition & 1 deletion ...nagednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def _build_schema_on_200(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down
2 changes: 1 addition & 1 deletion ...managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_wait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def _build_schema_on_200(cls):
serialized_name="networkTapId",
flags={"read_only": True},
)
properties.polling_interval_in_seconds = AAZFloatType(
properties.polling_interval_in_seconds = AAZIntType(
serialized_name="pollingIntervalInSeconds",
)
properties.provisioning_state = AAZStrType(
Expand Down
2 changes: 1 addition & 1 deletion src/managednetworkfabric/azext_managednetworkfabric/azext_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"azext.isPreview": true,
"azext.minCliCoreVersion": "2.67.0"
"azext.minCliCoreVersion": "2.70.0"
}
2 changes: 1 addition & 1 deletion src/managednetworkfabric/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


# HISTORY.rst entry.
VERSION = '8.0.0b4'
VERSION = '8.0.0b5'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down
Loading