Support ManagedSystem mode NodePool #8891

hao1939 · 2025-06-23T05:07:13Z

ManagedSystem Pool Support.
This feature introduces support for ManagedSystem node pools, enabling users to:

Create Kubernetes clusters with a fully managed system node pool: aks create --resource-group={resource_group} --name={name} --enable-managed-system-pool
Create new node pools in ManagedSystem mode: aks nodepool add --resource-group={resource_group} --cluster-name={name} --name={nodepool_name} --mode ManagedSystem
Delete ManagedSystem Pool: aks nodepool delete --resource-group={resource_group} --cluster-name={name} --name={nodepool_name}
Reconcile ManagedSystem Pool: aks nodepool update --resource-group={resource_group} --cluster-name={name} --name={nodepool_name}

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g MyResourceGroup -n MyManagedCluster --managed-system-pool

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2025-06-23T05:07:15Z

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule cmd_name rule_message suggest_message

❌ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_managed_system_pool

⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter mode: updated property choices from ['Gateway', 'System', 'User'] to ['Gateway', 'ManagedSystem', 'System', 'User']

⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter mode: updated property choices from ['Gateway', 'System', 'User'] to ['Gateway', 'ManagedSystem', 'System', 'User']

azure-client-tools-bot-prd · 2025-06-23T05:07:18Z

Hi @hao1939,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

github-actions · 2025-06-23T05:07:24Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

yonzhan · 2025-06-23T05:07:25Z

Thank you for your contribution! We will review the pull request and get back to you soon.

Copilot

Pull Request Overview

This PR introduces support for a new ManagedSystem node pool mode that resets all properties except name and mode for both create and update operations. It adds the constant, CLI parameter, help text, decorator logic, and tests to cover the add flow.

Implemented set_up_managed_system_mode in agentpool_decorator.py with early exit in construct_agentpool_profile_preview.
Added ManagedSystem to constants (_consts.py), CLI parameters (_params.py), and help (_help.py).
Added unit tests for the add-decorator behavior in test_agentpool_decorator.py.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/aks-preview/.../tests/latest/test_agentpool_decorator.py	Added tests for ManagedSystem mode on create and update decorators
src/aks-preview/.../agentpool_decorator.py	Implemented `set_up_managed_system_mode` and early return in preview logic
src/aks-preview/.../_params.py	Included `ManagedSystem` in `node_mode_types` and related imports
src/aks-preview/.../_help.py	Updated help text to explain `ManagedSystem` behavior
src/aks-preview/.../_consts.py	Defined `CONST_NODEPOOL_MODE_MANAGEDSYSTEM` constant

Comments suppressed due to low confidence (2)

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py:1996

In the update-path test you're instantiating AKSPreviewAgentPoolAddDecorator instead of AKSPreviewAgentPoolUpdateDecorator. Swap to the update decorator to correctly cover the update flow.

    def test_update_to_managed_system_mode(self):

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py:1391

[nitpick] Consider adding an end-to-end unit test for AKSPreviewAgentPoolUpdateDecorator.construct_agentpool_profile_preview when mode is ManagedSystem to ensure the update path also resets properties correctly.

    def test_construct_agentpool_profile_preview_managed_system(self):

github-actions · 2025-06-23T05:10:59Z

Hi @hao1939

Release Suggestions

Module: aks-preview

Update VERSION to 18.0.0b19 in src/aks-preview/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

FumingZhang · 2025-06-23T07:54:37Z

/azp run

azure-pipelines · 2025-06-23T07:54:50Z

Azure Pipelines successfully started running 2 pipeline(s).

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py

FumingZhang · 2025-06-23T07:58:49Z

seems the live test failed with error

  if self.agentpool_decorator_mode == AgentPoolDecoratorMode.MANAGED_CLUSTER:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E AttributeError: 'AKSPreviewAgentPoolAddDecoratorCommonTestCase' object has no attribute 'agentpool_decorator_mode'

FumingZhang · 2025-06-24T04:19:01Z

/azp run

azure-pipelines · 2025-06-24T04:19:13Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang

Could you please add a scenario test case for this feature? May check existing examples in test_aks_commands.py

src/aks-preview/azext_aks_preview/tests/latest/demo_enable_managed_system_pool.py

src/aks-preview/azext_aks_preview/_params.py

src/aks-preview/azext_aks_preview/agentpool_decorator.py

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

FumingZhang · 2025-06-25T04:05:15Z

/azp run

azure-pipelines · 2025-06-25T04:05:27Z

Azure Pipelines successfully started running 2 pipeline(s).

hao1939 · 2025-07-09T02:39:21Z

/azp run

azure-pipelines · 2025-07-09T02:39:28Z

Commenter does not have sufficient privileges for PR 8891 in repo Azure/azure-cli-extensions

FumingZhang · 2025-07-09T03:24:53Z

/azp run

azure-pipelines · 2025-07-09T03:25:06Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2025-07-09T04:01:58Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

        self.__raw_parameters = raw_parameters
        super().__init__(cmd, client, raw_parameters, resource_type)

+    def update_managed_system_pools(self, mc: ManagedCluster) -> ManagedCluster:


there's no corresponding option for command aks update, so this just acts as a guard?

BTW, this made me realize that other client tools probably don’t know that they need to clear other properties when switching nodepool mode to managed system. If the rp validation is strict, this will result in a bad request, resulting in a bad user experience.

Mode is not allowed for updating, so we are not worried CX would change the mode.
For ManagedSystem Pool, because we restrict the api to reject any extra field but not ignore, so we need to clear those properties while reconciling.

FumingZhang · 2025-07-09T04:03:42Z

src/aks-preview/azext_aks_preview/agentpool_decorator.py

+        # Check if mode is ManagedSystem, if yes, reset all properties
+        agentpool = self.set_up_managed_system_mode(agentpool)
+
+        # If mode is ManagedSystem, skip all other property setups
+        if agentpool.mode == CONST_NODEPOOL_MODE_MANAGEDSYSTEM:
+            return agentpool
+


what about putting it to the end of this constructor, then you don't need the check and return early.

quit early could skip unnecessary code branch

FumingZhang · 2025-07-09T04:08:23Z

src/aks-preview/azext_aks_preview/agentpool_decorator.py

+        # Check if agentpool is in ManagedSystem mode and handle special case
+        if agentpool.mode == CONST_NODEPOOL_MODE_MANAGEDSYSTEM:
+            # Make sure all other attributes are None
+            for attr in vars(agentpool):
+                if attr != 'name' and attr != 'mode' and not attr.startswith('_'):
+                    if hasattr(agentpool, attr):
+                        setattr(agentpool, attr, None)
+            return agentpool


what about wrapping this as a function (maybe add a helper function to do the clean up), and put it to the end of this update function?

FumingZhang · 2025-07-09T05:55:54Z

/azp run

azure-pipelines · 2025-07-09T05:56:07Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2025-07-09T23:32:23Z

/azp run

azure-pipelines · 2025-07-09T23:32:36Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2025-07-10T05:05:07Z

Live test passed!

test_aks_create_normal_cluster_then_add_managed_system_pool
test_aks_create_with_managed_system_pool_multiple_fails
test_aks_update_with_managed_system_pool

yanzhudd · 2025-07-14T01:27:34Z

Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.

hao1939 · 2025-07-14T05:15:39Z

Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.

hao1939 · 2025-07-14T05:17:47Z

Thanks @yanzhudd! Added, could you help to take a second look?

yanzhudd · 2025-07-14T05:26:44Z

src/aks-preview/HISTORY.rst

 18.0.0b18
 +++++++
 * Add validation error when neither --location or --cluster and --resource-group-name are specified for az extension type list or az extension type version list
+* Add support for `ManagedSystem` Agent Pool Mode.


please move it to below the Pending part

Suggested change

18.0.0b18

+++++++

* Add validation error when neither --location or --cluster and --resource-group-name are specified for az extension type list or az extension type version list

* Add support for `ManagedSystem` Agent Pool Mode.

* Add support for `ManagedSystem` Agent Pool Mode.

18.0.0b18

+++++++

* Add validation error when neither --location or --cluster and --resource-group-name are specified for az extension type list or az extension type version list

As yan suggested, please move your release note to the pending section if you don't want to release a new version immediately. Otherwise, please add a new section with version number 18.0.0b19 and update setup.py accordingly.

sure, updated.

FumingZhang · 2025-07-14T05:54:46Z

/azp run

azure-pipelines · 2025-07-14T05:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Copilot AI review requested due to automatic review settings June 23, 2025 05:07

hao1939 requested review from FumingZhang and andyliuliming as code owners June 23, 2025 05:07

azure-client-tools-bot-prd bot added this to the July 2025 (2025-07-01) milestone Jun 23, 2025

Copilot AI reviewed Jun 23, 2025

View reviewed changes

yonzhan requested a review from zhoxing-ms June 23, 2025 05:48

yonzhan assigned zhoxing-ms Jun 23, 2025

yonzhan requested a review from yanzhudd June 23, 2025 05:49

FumingZhang reviewed Jun 23, 2025

View reviewed changes

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Show resolved Hide resolved

hao1939 force-pushed the hayua/managedpool branch 6 times, most recently from 2828d7e to 0a1025d Compare June 23, 2025 13:58

FumingZhang reviewed Jun 24, 2025

View reviewed changes

hao1939 force-pushed the hayua/managedpool branch 2 times, most recently from 5029a45 to 1e0de7b Compare June 24, 2025 08:43

fix none

2ab4478

FumingZhang reviewed Jul 9, 2025

View reviewed changes

fix test

8f53d29

use recording from pipeline

42ec236

FumingZhang previously approved these changes Jul 10, 2025

View reviewed changes

hao1939 changed the title ~~Create a nodepool with ManagedSystem mode~~ Support ManagedSystem mode AgentPool Jul 11, 2025

hao1939 changed the title ~~Support ManagedSystem mode AgentPool~~ Support ManagedSystem mode NodePool Jul 11, 2025

hao1939 dismissed FumingZhang’s stale review via e9c30b6 July 14, 2025 05:15

hao1939 closed this Jul 14, 2025

hao1939 reopened this Jul 14, 2025

yanzhudd reviewed Jul 14, 2025

View reviewed changes

add history

908b1d8

hao1939 force-pushed the hayua/managedpool branch from e9c30b6 to 908b1d8 Compare July 14, 2025 05:49

FumingZhang approved these changes Jul 14, 2025

View reviewed changes

yanzhudd approved these changes Jul 14, 2025

View reviewed changes

yanzhudd merged commit c464eba into Azure:main Jul 14, 2025
24 checks passed

Support ManagedSystem mode NodePool #8891

Support ManagedSystem mode NodePool #8891

Uh oh!

Conversation

hao1939 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Jun 23, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

yonzhan commented Jun 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Suggestions

Module: aks-preview

Notes

Uh oh!

FumingZhang commented Jun 23, 2025

Uh oh!

azure-pipelines bot commented Jun 23, 2025

Uh oh!

Uh oh!

FumingZhang commented Jun 23, 2025

Uh oh!

FumingZhang commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FumingZhang commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

hao1939 commented Jul 9, 2025

Uh oh!

azure-pipelines bot commented Jul 9, 2025

Uh oh!

FumingZhang commented Jul 9, 2025

Uh oh!

azure-pipelines bot commented Jul 9, 2025

Uh oh!

FumingZhang Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

hao1939 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

FumingZhang Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

hao1939 Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FumingZhang Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Jul 9, 2025

Uh oh!

hao1939 commented Jun 23, 2025 •

edited

Loading

azure-client-tools-bot-prd bot commented Jun 23, 2025 •

edited

Loading

github-actions bot commented Jun 23, 2025 •

edited

Loading

hao1939 Jul 9, 2025 •

edited

Loading