Skip to content

Conversation

@nshankar13
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 27, 2025 16:04
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 27, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @nshankar13,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ASM e2e testing logic to return the second latest revision when available. Key changes include:

  • Modifying _get_asm_supported_revision to return the second latest revision if more than one exists.
  • Updating test_aks_commands.py to use the resource group's location when determining the revision.
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:169

  • The variable name 'sorted_revisons' appears to be misspelled. Consider renaming it to 'sorted_revisions' for improved clarity.
        sorted_revisons = self._sort_revisions(revisions)

@github-actions
Copy link

Signed-off-by: nshankar <[email protected]>
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change, test passed!

  • test_aks_azure_service_mesh_with_egress_gateway

"location": resource_group_location,
"ssh_key_value": self.generate_ssh_keys(),
"revision": self._get_asm_supported_revision("westus2"), # Temporarily set to prod region to avoid using unsupported ASM revision for centraluseap
"revision": self._get_asm_supported_revision(resource_group_location, True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see the fix works, but I am curious why this test case needs the second latest version, what makes it special?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set the default location to eastus2euap, whereas other scenarios are westus2 - this is because for Static Egress Gateway, I was previously running into quota issues for the gateway nodepool in the CLI e2es test when I used westus2 as the location.

However, eastus2euap returns a different list of revisions compared to westus2 - so I need to make sure that the revision is supported by using the second to last one.

@yanzhudd yanzhudd merged commit 2aa7bd5 into Azure:main Jul 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants