-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use 2nd latest revision for ASM e2e #8908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 2nd latest revision for ASM e2e #8908
Conversation
Signed-off-by: nshankar <[email protected]>
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @nshankar13, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ASM e2e testing logic to return the second latest revision when available. Key changes include:
- Modifying _get_asm_supported_revision to return the second latest revision if more than one exists.
- Updating test_aks_commands.py to use the resource group's location when determining the revision.
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:169
- The variable name 'sorted_revisons' appears to be misspelled. Consider renaming it to 'sorted_revisions' for improved clarity.
sorted_revisons = self._sort_revisions(revisions)
|
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change, test passed!
- test_aks_azure_service_mesh_with_egress_gateway
| "location": resource_group_location, | ||
| "ssh_key_value": self.generate_ssh_keys(), | ||
| "revision": self._get_asm_supported_revision("westus2"), # Temporarily set to prod region to avoid using unsupported ASM revision for centraluseap | ||
| "revision": self._get_asm_supported_revision(resource_group_location, True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad to see the fix works, but I am curious why this test case needs the second latest version, what makes it special?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set the default location to eastus2euap, whereas other scenarios are westus2 - this is because for Static Egress Gateway, I was previously running into quota issues for the gateway nodepool in the CLI e2es test when I used westus2 as the location.
However, eastus2euap returns a different list of revisions compared to westus2 - so I need to make sure that the revision is supported by using the second to last one.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.