Skip to content

Conversation

@frantran
Copy link
Member

@frantran frantran commented Jul 3, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az fleet ....

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 3, 2025 23:25
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 3, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️fleet
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd fleet autoupgradeprofile create cmd fleet autoupgradeprofile create added parameter long_term_support
⚠️ 1006 - ParaAdd fleet autoupgradeprofile create cmd fleet autoupgradeprofile create added parameter target_kubernetes_version
⚠️ 1010 - ParaPropUpdate fleet autoupgradeprofile create cmd fleet autoupgradeprofile create update parameter channel: updated property choices from ['NodeImage', 'Rapid', 'Stable'] to ['NodeImage', 'Rapid', 'Stable', 'TargetKubernetesVersion']
⚠️ 1011 - SubgroupAdd fleet gate sub group fleet gate added
⚠️ 1006 - ParaAdd fleet member create cmd fleet member create added parameter member_labels
⚠️ 1006 - ParaAdd fleet member update cmd fleet member update added parameter member_labels

@azure-client-tools-bot-prd
Copy link

Hi @frantran,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the vendored SDK for the 2025-04-01-preview Fleet API version, including marker files and all operation classes.

  • Introduces py.typed marker for PEP 561 compliance.
  • Adds complete operation modules (_update_runs_operations.py, _gates_operations.py, _fleets_operations.py, etc.) generated by AutoRest.
  • Includes a customization entry point in _patch.py.

Reviewed Changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
py.typed PEP 561 marker file
_update_runs_operations.py Full CRUD and LRO support for UpdateRun resources
_patch.py SDK customization entry point
_operations.py Core provider operations
_gates_operations.py Operations for Gate resources
_fleets_operations.py Operations for Fleet resources
_fleet_update_strategies_operations.py Operations for FleetUpdateStrategy resources
Comments suppressed due to low confidence (2)

src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_patch.py:12

  • [nitpick] The __all__ list is empty, which means no symbols are publicly exposed at this level. Either populate it with the intended public customizations or remove it to avoid confusion.
__all__: List[str] = []  # Add all objects you want publicly available to users at this package level

src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py:1449

  • The generated UpdateRuns operations are not covered by any tests. Adding unit or integration tests for methods like list_by_fleet, get, and the LRO variants will help catch regressions.
        )

@frantran frantran changed the title add 04-01 api add Fleet 04-01 api CLI support Jul 3, 2025
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

@yonzhan yonzhan requested a review from kairu-ms July 4, 2025 07:02
@yonzhan yonzhan requested a review from jsntcy July 4, 2025 07:03
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@frantran
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8938 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 18, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 18, 2025

Please fix CI issues

Copy link
Contributor

@dvadas dvadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/fleet/azext_fleet/custom.py, method get_update_run_strategy, lines 485-496, we also need to parse the before/afterGates JSON and include those structures in the group and stage models.

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit cf8a997 into Azure:main Jul 30, 2025
29 of 30 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ fleet-1.6.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132088636&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants