Skip to content

Conversation

@Shivani-Msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 29, 2025 21:01
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a post-commit bug in Azure Virtual Network Manager (AVNM) by incrementing the version from 2.0.0 to 2.0.1 and documenting the fix in the release history.

  • Version bump from 2.0.0 to 2.0.1 with explanatory comment
  • Added changelog entry documenting the AVNM post-commit fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/network-manager/setup.py Updated version to 2.0.1 with comment explaining the routing fix
src/network-manager/HISTORY.rst Added changelog entry for version 2.0.1 documenting the AVNM post-commit bug fix


# HISTORY.rst entry.
VERSION = '2.0.0'
# Fixed post commit issue in routing
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment should use past tense consistently. Consider changing 'Fixed' to 'Fix' to match the changelog entry, or change both to use past tense: 'Fixed post-commit issue in routing'.

Suggested change
# Fixed post commit issue in routing
# Fix post commit issue in routing

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Copy link
Contributor Author

@Shivani-Msft Shivani-Msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for Post commit in AVNM code Review

@Shivani-Msft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@kairu-ms kairu-ms merged commit d73e2af into Azure:main Aug 6, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 7, 2025

[Release] Update index.json for extension [ network-manager-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132969955&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants