-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix AVNM post commit bug #9020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AVNM post commit bug #9020
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a post-commit bug in Azure Virtual Network Manager (AVNM) by incrementing the version from 2.0.0 to 2.0.1 and documenting the fix in the release history.
- Version bump from 2.0.0 to 2.0.1 with explanatory comment
- Added changelog entry documenting the AVNM post-commit fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/network-manager/setup.py | Updated version to 2.0.1 with comment explaining the routing fix |
| src/network-manager/HISTORY.rst | Added changelog entry for version 2.0.1 documenting the AVNM post-commit bug fix |
|
|
||
| # HISTORY.rst entry. | ||
| VERSION = '2.0.0' | ||
| # Fixed post commit issue in routing |
Copilot
AI
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment should use past tense consistently. Consider changing 'Fixed' to 'Fix' to match the changelog entry, or change both to use past tense: 'Fixed post-commit issue in routing'.
| # Fixed post commit issue in routing | |
| # Fix post commit issue in routing |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
This reverts commit a628ff6.
…re-cli-extensions into feature-shivani
Shivani-Msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for Post commit in AVNM code Review
|
@microsoft-github-policy-service agree company="Microsoft" |
|
[Release] Update index.json for extension [ network-manager-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132969955&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.