-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix AVNM post commit bug #9020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix AVNM post commit bug #9020
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c4f7848
Fix issues with Post commit in Routing
Shivani-Msft 10f699c
Fix the network manager extension version
Shivani-Msft a24d584
Merge branch 'Azure:main' into main
Shivani-Msft e607cb2
Update the history file
Shivani-Msft a628ff6
Fix failing build
Shivani-Msft 77e3838
Merge branch 'Azure:main' into feature-shivani
Shivani-Msft 619a0be
Revert "Fix failing build"
Shivani-Msft 02c8be1
Merge branch 'feature-shivani' of https://github.com/Shivani-Msft/azu…
Shivani-Msft 7c44674
Merge branch 'Azure:main' into feature-shivani
Shivani-Msft 08f02ba
Upload new recordings
Shivani-Msft b30da04
Fix Test cases
Shivani-Msft 2319b02
Fix Test coverage
Shivani-Msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -745,4 +745,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -846,4 +846,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -649,4 +649,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -389,4 +389,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -381,4 +381,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,4 +188,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -381,4 +381,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -597,4 +597,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
2,695 changes: 1,649 additions & 1,046 deletions
2,695
...twork_manager/tests/latest/recordings/test_network_manager_reachability_analysis_run.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1126,4 +1126,4 @@ interactions: | |
| status: | ||
| code: 404 | ||
| message: Not Found | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -385,4 +385,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -395,4 +395,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -397,4 +397,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
4,215 changes: 2,625 additions & 1,590 deletions
4,215
.../azext_network_manager/tests/latest/recordings/test_network_manager_static_cidr_crud.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -485,4 +485,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -556,4 +556,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -521,4 +521,4 @@ interactions: | |
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 | ||
| version: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment should use past tense consistently. Consider changing 'Fixed' to 'Fix' to match the changelog entry, or change both to use past tense: 'Fixed post-commit issue in routing'.