[AKS] az aks create/update: Update recording rule group create logic for managed prometheus addon#30857
Merged
[AKS] az aks create/update: Update recording rule group create logic for managed prometheus addon#30857
az aks create/update: Update recording rule group create logic for managed prometheus addon#30857Conversation
…c for managed prometheus addon
bragi92
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bragi92, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
Member
Author
|
Ran live_test successfully with
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bragi92
changed the title
az aks create/update: Update recording rule group create logic for managed prometheus addon
bragi92
changed the title
az aks create/update: Update recording rule group create logic for managed prometheus addonaz aks create/update : Update recording rule group create logic for managed prometheus addon
Member
Author
|
Fixed formatting issue in PR title. |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30857 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Feb 25, 2025
Member
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
- test_aks_create_with_azuremonitormetrics
- test_aks_update_with_azuremonitormetrics
Collaborator
|
Please fix CI issues |
Member
|
need to remove the extra space before colon |
bragi92
changed the title
az aks create/update : Update recording rule group create logic for managed prometheus addonaz aks create/update: Update recording rule group create logic for managed prometheus addon
Member
Author
|
Updated to remove extra space. @FumingZhang Can you help run the PR build again? |
Member
|
@bragi92 I don't have the permission to queue the CI. BTW, seems the code complete has passed. In this case, you'll need to wait for another few days for cli team to merge your change. |
Member
Author
|
@yanzhudd Can you please help with re-running the test as I've updated the title and with the PR merge if it looks good to you. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"az aks create -n kaveeshcli22 -g kaveeshcli --disable-azure-monitor-metricsDescription
The recording rules manifest has been updated in TiP and will soon be deployed to production which will include other alerts rule recommendations. I'm updating the CLI code to filter down to the rule groups that the managed prometheus needs for onboarding in this PR.
Testing Guide
Scenario 1 : Region where TiP manifest is available
az aks create -n kaveeshcli22 -g kaveeshcli --location westcentralus --enable-azure-monitor-metrics"and it should result in a success. (Currently the change is only deployed to westcentralus)Scenario 2 : Region where TiP manifest is not available
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics"and it should result in a success.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.