[ACR] az acr connected-registry create/update: Add new parameters for enabling and setting interval for garbage collection within a connected registry#30956
Merged
zhoxing-ms merged 13 commits intoAzure:devfrom Apr 23, 2025
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr connected-registry create | cmd acr connected-registry create added parameter garbage_collection_enabled |
||
| acr connected-registry create | cmd acr connected-registry create added parameter garbage_collection_schedule |
||
| acr connected-registry update | cmd acr connected-registry update added parameter garbage_collection_enabled |
||
| acr connected-registry update | cmd acr connected-registry update added parameter garbage_collection_schedule |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
trisavo-msft
changed the title
trisavo-msft
changed the title
huanwu
reviewed
Mar 6, 2025
| 'child_name': childName, | ||
| 'grandchild_name': grandchildName, | ||
| 'rg_loc': 'eastus', | ||
| 'rg_loc': 'westcentralus', |
Contributor
There was a problem hiding this comment.
Question, why need make this change?
Member
Author
There was a problem hiding this comment.
It was initially for testing to verify garbage collection since the RP release made it to westcentralus. I will change it back to eastus.
trisavo-msft
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
previously approved these changes
Apr 1, 2025
Contributor
|
@trisavo-msft Please address these CI issues |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
trisavo-msft
changed the title
zhoxing-ms
changed the title
az acr connected-registry create/update: Add new arguments for enabling and setting interval for garbage collection within a connected registry
zhoxing-ms
approved these changes
Apr 21, 2025
zhoxing-ms
changed the title
az acr connected-registry create/update: Add new arguments for enabling and setting interval for garbage collection within a connected registryaz acr connected-registry create/update: Add new parameters for enabling and setting interval for garbage collection within a connected registry
Contributor
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az acr connected-registry create, az acr connected-registry update
Description
Testing Guide
History Notes
[ACR]
az acr connected-registry create/update: Add new parameter--gc-enabledwhich enables or disables garbage collection on a connected registry[ACR]
az acr connected-registry create/update: Added new parameter--gc-schedulewhich uses cron expression to set a collection interval.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.