Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network application-gateway waf-policy create | cmd network application-gateway waf-policy create update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
||
| network application-gateway waf-policy managed-rule exclusion rule-set add | cmd network application-gateway waf-policy managed-rule exclusion rule-set add update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
||
| network application-gateway waf-policy managed-rule exclusion rule-set remove | cmd network application-gateway waf-policy managed-rule exclusion rule-set remove update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
||
| network application-gateway waf-policy managed-rule rule-set add | cmd network application-gateway waf-policy managed-rule rule-set add update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
||
| network application-gateway waf-policy managed-rule rule-set remove | cmd network application-gateway waf-policy managed-rule rule-set remove update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
||
| network application-gateway waf-policy managed-rule rule-set update | cmd network application-gateway waf-policy managed-rule rule-set update update parameter rule_set_version: removed property choices=['0.1', '1.0', '1.1', '2.1', '2.2.9', '3.0', '3.1', '3.2'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes local validation of rule set versions for the WAF (Web Application Firewall) policy commands to support Azure's increasing release cadence. The change allows the CLI to accept any version string instead of being restricted to a predefined list of versions.
- Removes the
RULESET_VERSIONconstant that defined allowed versions - Updates WAF policy commands to accept any version string without local validation
- Maintains backward compatibility by keeping the default version as "2.1"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/custom.py | Removes RULESET_VERSION constant and enum validation from rule set version parameter |
| src/azure-cli/azure/cli/command_modules/network/_params.py | Removes import and usage of RULESET_VERSION enum in parameter definition |
Comments suppressed due to low confidence (1)
Member
|
let's add a test case for 2.2. |
necusjz
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway waf-policy managed-rule rule-set add/updateaz network application-gateway waf-policy createDescription
resolve #31932
Remove local validation of rule set version, for increasing release cadence.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.