Skip to content

{Network} az network application-gateway waf-policy: Remove local validation of rule set versions #31935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 1 commit into from
Aug 14, 2025
Merged

{Network} az network application-gateway waf-policy: Remove local validation of rule set versions #31935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/azure-cli/azure/cli/command_modules/network/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
from azure.cli.command_modules.network._actions import (
TrustedClientCertificateCreate,
SslProfilesCreate, AddMappingRequest, WAFRulesCreate)
from azure.cli.command_modules.network.custom import RULESET_VERSION


# pylint: disable=too-many-locals, too-many-branches, too-many-statements
Expand Down Expand Up @@ -230,7 +229,6 @@ def load_arguments(self, _):
help='The type of the web application firewall rule set.')
c.argument('rule_set_version',
options_list='--version',
arg_type=get_enum_type(RULESET_VERSION.values()),
help='The version of the web application firewall rule set type. '
'0.1, 1.0, and 1.1 are used for Microsoft_BotManagerRuleSet.')

Expand Down
4 changes: 1 addition & 3 deletions src/azure-cli/azure/cli/command_modules/network/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@
RecordSetCAADelete as DNSRecordSetCAADelete, RecordSetCNAMEDelete as DNSRecordSetCNAMEDelete)

logger = get_logger(__name__)
RULESET_VERSION = {"0.1": "0.1", "1.0": "1.0", "1.1": "1.1", "2.1": "2.1", "2.2.9": "2.2.9", "3.0": "3.0", "3.1": "3.1", "3.2": "3.2"}

remove_basic_option_msg = "It's recommended to create with `%s`. " \
"Please be aware that Basic option will be removed in the future."
Expand Down Expand Up @@ -1948,8 +1947,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
options=["--version"],
help="Version of the web application firewall rule set type. "
"0.1, 1.0, and 1.1 are used for Microsoft_BotManagerRuleSet",
default="2.1",
enum=RULESET_VERSION
default="2.1"
)
return args_schema

Expand Down
Loading