[AKS] az aks create/update: Fix handling for --container-storage-version parameter#32015
Merged
[AKS] az aks create/update: Fix handling for --container-storage-version parameter#32015
az aks create/update: Fix handling for --container-storage-version parameter#32015Conversation
nearora-msft
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create update parameter container_storage_version: added property choices=['1', '2'] |
||
| aks update | cmd aks update update parameter container_storage_version: added property choices=['1', '2'] |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Azure Container Storage version handling in AKS commands by adding support for version '2' and improving validation logic. The changes ensure users can specify version '2' (which follows the same behavior as the latest version) and prevent invalid parameter combinations.
- Added validation to reject unsupported Azure Container Storage versions
- Added validation to prevent using
--container-storage-versionwith--disable-azure-container-storage - Extended supported versions to include both '1' and '2'
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| managed_cluster_decorator.py | Added version validation logic and parameter conflict checks for Azure Container Storage configuration |
| _consts.py | Added constant for supported Azure Container Storage versions including '1' and '2' |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
FumingZhang
reviewed
Aug 28, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
You could consider declaring the option in _params.py as shown below. This way, the CLI framework can help validate the value, which would save you some effort.
c.argument(
"container_storage_version",
arg_type=get_enum_type(CONST_SUPPORTED_ACSTOR_VERSIONS),
)
0053e92 to
aeba916
Compare
Contributor
Author
Fixed. |
FumingZhang
approved these changes
Aug 29, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
|
Please fix CI issues |
…r-storage-version parameter
nearora-msft
force-pushed
the
nearora/acstorfixes
branch
from
aeba916 to
f472334
Compare
Member
|
Queued live test (re-queued for temp failures) to validate the change, test passed!
|
FumingZhang
approved these changes
Sep 8, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
az aks update
Description
Testing Guide
az aks update -g test-rg -n test-cluster --enable-azure-container-storage --container-storage-version 2
az aks create -g test-rg -n test-cluster --enable-azure-container-storage --container-storage-version 2
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.