feat: make OverlayExtensionConfig ExtensionIPRange field immutable
#3056
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robogatikov
changed the title
ExtensionIPRange field immutable
Member
|
Can you update the description to include "why?" There's not enough context here to understand why this particular field should be immutable as opposed to others. |
Contributor
Author
Yeah, it was not very clear from the description. I hope it is better now. |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
robogatikov
force-pushed
the
robogatikov/oec-immutable
branch
from
0aac222 to
0b8ab26
Compare
robogatikov
force-pushed
the
robogatikov/oec-immutable
branch
from
0b8ab26 to
57e43dd
Compare
nairashu
previously approved these changes
Oct 30, 2024
robogatikov
force-pushed
the
robogatikov/oec-immutable
branch
from
f3172d1 to
3a1d96c
Compare
robogatikov
force-pushed
the
robogatikov/oec-immutable
branch
3 times, most recently
from
993ede8 to
adbd9c6
Compare
robogatikov
force-pushed
the
robogatikov/oec-immutable
branch
from
d4aa6f8 to
1b65587
Compare
3 tasks
nairashu
approved these changes
Oct 31, 2024
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Commenter does not have sufficient privileges for PR 3056 in repo Azure/azure-container-networking |
Collaborator
|
/azp run Azure Container Networking PR |
1 similar comment
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…3056) feat: make extensionIPRange field immutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We want to make OverlayExtensionConfig
extensionIPRangefield immutable to prevent accidental changes to the field. Network Containers are getting programmed for every IP address in this field's CIDR range, and DNC/DNC-RC will not support updating this field.Issue Fixed:
Requirements:
Notes: