Skip to content

feat: make OverlayExtensionConfig ExtensionIPRange field immutable #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat: make OverlayExtensionConfig ExtensionIPRange field immutable #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ type OverlayExtensionConfigList struct {
}

// OverlayExtensionConfigSpec defines the desired state of OverlayExtensionConfig.
// +kubebuilder:validation:XValidation:rule="!has(oldSelf.extensionIPRange) || has(self.extensionIPRange)", message="ExtensionIPRange is required once set"
type OverlayExtensionConfigSpec struct {
// ExtensionIPRange field defines a CIDR that should be able to reach routing domain ip addresses.
// +kubebuilder:validation:Optional
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
// +kubebuilder:validation:MaxLength=43
// 43 is max length of IPv6 CIDR string
ExtensionIPRange string `json:"extensionIPRange,omitempty"`
}

Expand Down
12 changes: 10 additions & 2 deletions crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,18 @@ spec:
description: OverlayExtensionConfigSpec defines the desired state of OverlayExtensionConfig.
properties:
extensionIPRange:
description: ExtensionIPRange field defines a CIDR that should be
able to reach routing domain ip addresses.
description: |-
ExtensionIPRange field defines a CIDR that should be able to reach routing domain ip addresses.
43 is max length of IPv6 CIDR string
maxLength: 43
type: string
x-kubernetes-validations:
- message: Value is immutable
rule: self == oldSelf
type: object
x-kubernetes-validations:
- message: ExtensionIPRange is required once set
rule: '!has(oldSelf.extensionIPRange) || has(self.extensionIPRange)'
status:
description: OverlayExtensionConfigStatus defines the observed state of
OverlayExtensionConfig
Expand Down
Loading