Skip to content

ci: fix check-shadowing not allowed #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

ci: fix check-shadowing not allowed #3432

merged 1 commit into from
Feb 19, 2025

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Feb 19, 2025 •
edited
Loading

Reason for Change:

Golint failing with invalid config

Issue Fixed:

Modifies config to conform to https://golangci-lint.run/usage/linters/#govet

Requirements:

Notes:

@QxBytes QxBytes added the ci Infra or tooling. label Feb 19, 2025
@QxBytes QxBytes self-assigned this Feb 19, 2025
@QxBytes
Copy link
Contributor Author

QxBytes commented Feb 19, 2025

/azp run Azure Container Networking PR

@QxBytes QxBytes marked this pull request as ready for review February 19, 2025 18:05
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings February 19, 2025 18:05
@QxBytes QxBytes requested a review from a team as a code owner February 19, 2025 18:05
@QxBytes QxBytes requested a review from csfmomo February 19, 2025 18:05
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@rbtr rbtr enabled auto-merge February 19, 2025 18:41
@rbtr rbtr added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit ddaa6e6 Feb 19, 2025
22 checks passed
@rbtr rbtr deleted the alew/golint-fix branch February 19, 2025 22:58
QxBytes added a commit that referenced this pull request Feb 26, 2025
@QxBytes
ci: fix check-shadowing not allowed (#3432)
7d72635 
fix check-shadowing not allowed
QxBytes added a commit that referenced this pull request Feb 26, 2025
@QxBytes
ci: fix check-shadowing not allowed (#3432)
c83e8ce 
fix check-shadowing not allowed
This was referenced Feb 26, 2025
Merged
Merged
QxBytes added a commit that referenced this pull request Feb 27, 2025
@QxBytes
backport: ci: fix check-shadowing not allowed (#3432) (#3455)
abb5cb6 
ci: fix check-shadowing not allowed (#3432)

fix check-shadowing not allowed
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
@QxBytes
backport: ci: fix check-shadowing not allowed (#3432) (#3456)
b3ee1dd 
ci: fix check-shadowing not allowed (#3432)

fix check-shadowing not allowed
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
@QxBytes
ci: fix check-shadowing not allowed (#3432)
0ce1515 
fix check-shadowing not allowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rbtr rbtr rbtr approved these changes

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@csfmomo csfmomo Awaiting requested review from csfmomo csfmomo is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@QxBytes QxBytes

Labels

ci Infra or tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@QxBytes @rbtr @jpayne3506