Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Adds an additional level of alerting for breaking changes occurring in upstream cilium.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added the ci Infra or tooling. label Apr 14, 2025
@jpayne3506 jpayne3506 self-assigned this Apr 14, 2025
Copilot AI review requested due to automatic review settings April 14, 2025 17:43
@jpayne3506 jpayne3506 requested a review from a team as a code owner April 14, 2025 17:43
@jpayne3506 jpayne3506 requested a review from nddq April 14, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@jpayne3506 jpayne3506 force-pushed the jpayne3506/nightly-error branch from 0069d78 to 411ce18 Compare April 14, 2025 17:48
@vipul-21
Copy link
Contributor

If we want to test the cilium logs for error, we can use the connectivity test for that. They have check log error and specify the log-check-levels as error so that it does not fail on warning.

@jpayne3506 jpayne3506 force-pushed the jpayne3506/nightly-error branch from 411ce18 to 0ca8d8a Compare April 14, 2025 21:25
@jpayne3506
Copy link
Contributor Author

https://github.com/cilium/cilium/pull/36231/files , got it. I think this only checks agent logs, so for now we can still leverage this for operator.

@jpayne3506 jpayne3506 force-pushed the jpayne3506/nightly-error branch from 3cac522 to 1e977db Compare April 15, 2025 18:22
@jpayne3506 jpayne3506 force-pushed the jpayne3506/nightly-error branch from 1e977db to 595267e Compare April 17, 2025 16:35
@jpayne3506 jpayne3506 enabled auto-merge May 1, 2025 22:57
@jpayne3506
Copy link
Contributor Author

jpayne3506 commented May 1, 2025

/azp run Azure Container Networking PR

@Azure Azure deleted a comment from azure-pipelines bot May 1, 2025
@Azure Azure deleted a comment from azure-pipelines bot May 1, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506 jpayne3506 added this pull request to the merge queue May 1, 2025
Merged via the queue into master with commit 7496dae May 2, 2025
15 of 16 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/nightly-error branch May 2, 2025 01:28
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* ci: create log check template

* ci: add log check to cilium nightly

* chore: clean up spacing.

* ci: move log check, address nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants