Skip to content

fix: use "vEthernet (LoopbackAdapterHostNCConnectivity)" when CNS is … #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

fix: use "vEthernet (LoopbackAdapterHostNCConnectivity)" when CNS is … #3693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cns/hnsclient/hnsclient_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ const (
// Name of the loopback adapter needed to create Host NC apipa network
hostNCLoopbackAdapterName = "LoopbackAdapterHostNCConnectivity"

// Name of the loopback adapter created by HNS for Host NC apipa network
vEthernethostNCLoopbackAdapterName = "vEthernet (" + hostNCLoopbackAdapterName + ")"

// HNS rehydration issue requires this GW to be different than the loopback adapter ip, so we set it to .2
defaultHnsGwIPAddress = "169.254.128.2"
hnsLoopbackAdapterIPAddress = "169.254.128.1"
Expand Down Expand Up @@ -301,7 +304,16 @@ func createHostNCApipaNetwork(
}

// Create loopback adapter needed for this HNS network
if interfaceExists, _ := networkcontainers.InterfaceExists(hostNCLoopbackAdapterName); !interfaceExists {
// We need to fitst check the existence of either "LoopbackAdapterHostNCConnectivity" or the vEthernet(LoopbackAdapterHostNCConnectivity) interfaces
// If neither exists, we create the loopback adapter with the specified IP configuration.
loopbackInterfaceExists, _ := networkcontainers.InterfaceExists(hostNCLoopbackAdapterName)
vethernetLoopbackInterfaceExists, _ := networkcontainers.InterfaceExists(vEthernethostNCLoopbackAdapterName)
if loopbackInterfaceExists {
logger.Printf("%s already created, skipping loopback interface creation", hostNCLoopbackAdapterName)
}
if vethernetLoopbackInterfaceExists {
logger.Printf("%s already created, skipping loopback interface creation", vEthernethostNCLoopbackAdapterName)
} else if !loopbackInterfaceExists && !vethernetLoopbackInterfaceExists {
ipconfig := cns.IPConfiguration{
IPSubnet: cns.IPSubnet{
IPAddress: hnsLoopbackAdapterIPAddress,
Expand Down
Loading