feat: create new telemetry handle that supports connection strings #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new telemetry client that supports connection strings for initializing Application Insights telemetry, along with corresponding tests.
- Updated go.mod to replace the ApplicationInsights-Go dependency.
- Added a new function, NewAITelemetryWithConnectionString, in telemetrywrapper.go to enable connection string based initialization.
- Expanded tests in telemetrywrapper_test.go to cover the new connection string initialization.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updated ApplicationInsights-Go dependency replacement. |
| aitelemetry/telemetrywrapper_test.go | Added tests for connection string initialization and error checks. |
| aitelemetry/telemetrywrapper.go | Added NewAITelemetryWithConnectionString function implementation. |
Comments suppressed due to low confidence (1)
aitelemetry/telemetrywrapper_test.go:93
- There is a spelling mistake in the error message; 'intializing' should be changed to 'initializing'.
t.Errorf("Error intializing AI telemetry:%v", err)
BeegiiK
commented
Jun 11, 2025
BeegiiK
changed the title
BeegiiK
force-pushed
the
connection-string
branch
3 times, most recently
from
987145b to
fa88a0b
Compare
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
BeegiiK
force-pushed
the
connection-string
branch
from
132ce87 to
88d5717
Compare
Collaborator
|
@BeegiiK I'm not interested in maintaining a soft AppInsights fork. Have you talked to the owner of the repo to see if they would take this contribution? |
BeegiiK
force-pushed
the
connection-string
branch
from
3fa5448 to
ebec4dd
Compare
BeegiiK
force-pushed
the
connection-string
branch
2 times, most recently
from
1879644 to
127c175
Compare
rbtr
requested changes
Jul 15, 2025
Collaborator
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
previously approved these changes
Jul 16, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run NPM Scale Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BeegiiK
force-pushed
the
connection-string
branch
from
850849a to
8ed839f
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
previously approved these changes
Jul 23, 2025
apontejaj
previously approved these changes
Jul 23, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BeegiiK
force-pushed
the
connection-string
branch
from
c8facc2 to
16ec957
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gimotwanMSFT
approved these changes
Jul 23, 2025
byte-msft
approved these changes
Jul 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
…zure#3729) * feat: create new telemetry handle with connection strings * feat: Add application insights source code and remove dependency * feat: Create connection string helper function and update telemetry handle * feat: Polishing * feat: Address PR comments * feat: Update test telemetry handle initialization * feat: Re-initialise telemetry handles to fix race conditions during test execution * feat: revert string formatting changes * feat: fix lint
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…3729) * feat: create new telemetry handle with connection strings * feat: Add application insights source code and remove dependency * feat: Create connection string helper function and update telemetry handle * feat: Polishing * feat: Address PR comments * feat: Update test telemetry handle initialization * feat: Re-initialise telemetry handles to fix race conditions during test execution * feat: revert string formatting changes * feat: fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Currently, the telemetry handle can only work with instrumentation keys. If we want to use application insights in sovereign clouds, this would simply fail as the logging is shipped to a default ingestion endpoint and the
isPublicEnvironmentcheck.This PR introduces a new telemetry handle method that takes in a connection string, parses it, updates the configuration appropriately and initializes the new handle
Tested manually by updating DNC to use the new telemetry handle and verified that the logs were shipped to Kusto, with the connection string of the test application insights resource
Issue Fixed:
#3730
Requirements:
Notes: