perf: dhcp err msg in network swiftv2 code path #3793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes error messages in the DHCP and Swift V2 code paths to use kubelet.NetworkNotReadyErrorMsg so that the kubelet will retry with a faster backoff. It also updates tests to expect the new message and bumps Kubernetes module versions.
- Wrap DHCP discovery failures with the standard
NetworkNotReadyErrorMsg - Update Swift V2 middleware errors and tests to include
NetworkNotReadyErrorMsg - Bump k8s dependencies and update the devcontainer Go version
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| network/secondary_endpoint_linux_test.go | Add a DHCP-failure mock and update tests to expect NetworkNotReadyErrorMsg |
| network/secondary_endpoint_client_linux.go | Wrap DHCP error with kubelet.NetworkNotReadyErrorMsg |
| go.mod | Bump k8s.io and k8s.io/kubernetes dependencies |
| cns/middlewares/k8sSwiftV2_linux_test.go | Update tests to assert on NetworkNotReadyErrorMsg |
| cns/middlewares/k8sSwiftV2.go | Change Swift V2 error constants to use NetworkNotReadyErrorMsg |
| .devcontainer/devcontainer.json | Update Go feature to version 1.23.2 |
Comments suppressed due to low confidence (1)
network/secondary_endpoint_linux_test.go:382
- Missing import for the
netiopackage, which is required fornetio.NewMockNetIO. Please add the appropriate import, e.g.,"github.com/Azure/azure-container-networking/netio".
netioshim: netio.NewMockNetIO(false, 0),
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
requested changes
Jul 10, 2025
QxBytes
approved these changes
Jul 10, 2025
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Isaac <[email protected]>
isaac-dasan
force-pushed
the
isaac/swiftv2/dhcpErrMsgFix
branch
from
671e436 to
9d7b2be
Compare
Member
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
santhoshmprabhu
approved these changes
Jul 11, 2025
tamilmani1989
approved these changes
Jul 11, 2025
4 tasks
isaac-dasan
added a commit
that referenced
this pull request
Jul 11, 2025
* fix: dhcp error message to include kubelet err msg Signed-off-by: GitHub <[email protected]> * Update network/secondary_endpoint_client_linux.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Isaac <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Isaac <[email protected]> Co-authored-by: Copilot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 12, 2025
…3821) perf: dhcp err msg in network swiftv2 code path (#3793) * fix: dhcp error message to include kubelet err msg * Update network/secondary_endpoint_client_linux.go --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Isaac <[email protected]> Co-authored-by: Copilot <[email protected]>
NihaNallappagari
pushed a commit
to NihaNallappagari/azure-container-networking
that referenced
this pull request
Sep 4, 2025
* fix: dhcp error message to include kubelet err msg Signed-off-by: GitHub <[email protected]> * Update network/secondary_endpoint_client_linux.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Isaac <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Isaac <[email protected]> Co-authored-by: Copilot <[email protected]>
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* fix: dhcp error message to include kubelet err msg Signed-off-by: GitHub <[email protected]> * Update network/secondary_endpoint_client_linux.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Isaac <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Isaac <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The particular error message "network is not ready" will make kubelet retry with faster backOffInterval than default error messages.
https://github.com/kubernetes/kubernetes/blob/efd2a0d1f514be96a2f012fc3cb40f7c872b4e67/pkg/kubelet/pod_workers.go#L1495C2-L1501C3
Notes: