-
Notifications
You must be signed in to change notification settings - Fork 458
Fix .gitignore to allow PowerShell module bin folders #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: liliankasem <[email protected]>
/azp run coretools.public |
Azure Pipelines successfully started running 1 pipeline(s). |
@copilot Fix the following build warnings -
|
Co-authored-by: surgupta-msft <[email protected]>
... Fixed the StyleCop SA1028 warnings by removing trailing whitespace from lines 205, 209, 214, 275, 279, and 283 in GitIgnoreParserTests.cs. The build warnings should now be resolved. Commit: 738651f Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
/azp run coretools.public |
Azure Pipelines successfully started running 1 pipeline(s). |
@copilot Test |
Co-authored-by: surgupta-msft <[email protected]>
Fixed the failing test |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The generated .gitignore file was excluding all
bin
folders, which caused issues with PowerShell modules that contain essential DLL files in theirbin
directories. When customers saved PowerShell modules (like Az.Storage) to theModules
folder, the module's bin files would be excluded from git, causing runtime failures when those files couldn't be loaded.Problem
PowerShell modules from the PowerShell Gallery often include binary files in
bin
folders. For example, the Az.Storage module containsStorage.Autorest\bin\Az.Storage.private.dll
. With the previous gitignore pattern of simplybin
, these essential files were being excluded from source control.Solution
Updated the gitignore pattern to:
bin/
- excludes root-level bin folders**/bin/
- excludes nested bin folders anywhere in the project!Modules/**
- allows everything within Modules directories (including bin folders)Validation
The fix was validated with comprehensive tests showing:
bin/somefile.dll
are still properly ignoredsrc/bin/output.dll
are still properly ignoredModules/Az.Storage/8.1.0/Storage.Autorest/bin/Az.Storage.private.dll
are now allowedThis change maintains backward compatibility while specifically addressing the PowerShell module use case, ensuring that customers can include PowerShell modules with their binary dependencies in their function apps.
Fixes #4239.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
azfunc.pkgs.visualstudio.com
dotnet build --no-restore --verbosity minimal
(dns block)dotnet restore --verbosity minimal
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.