Skip to content

Fix .gitignore to allow PowerShell module bin folders #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix .gitignore to allow PowerShell module bin folders #4574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81d4700
Initial plan
Copilot Aug 6, 2025
99649c1
Fix gitignore to allow PowerShell module bin folders
Copilot Aug 6, 2025
738651f
Remove trailing whitespace from test file to fix StyleCop warnings
Copilot Aug 6, 2025
d04bd29
Fix failing PowerShell module test to use actual gitignore content
Copilot Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Cli/func/StaticResources/gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
bin
bin/
**/bin/
!Modules/**
obj
csx
.vs
Expand Down
20 changes: 20 additions & 0 deletions test/Cli/Func.UnitTests/ParserTests/GitIgnoreParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using Azure.Functions.Cli;
using Azure.Functions.Cli.Common;
using FluentAssertions;
using Xunit;
Expand Down Expand Up @@ -147,5 +148,24 @@ public void DeniesShouldNotDenyNestedUnignoredFilesInIgnoredDirectories()
{
_gitignore.Denies("nonexistent/foo/wat").Should().BeFalse();
}

[Fact]
public async void PowerShellModuleBinFoldersShouldBeHandledCorrectly()
{
// Test the current gitignore content from the actual static resource
var currentGitIgnore = await StaticResources.GitIgnore;

var currentParser = new GitIgnoreParser(currentGitIgnore);

// These paths should be ignored (regular bin folders)
currentParser.Denies("bin/somefile.dll").Should().BeTrue();
currentParser.Denies("src/bin/output.dll").Should().BeTrue();

// These PowerShell module paths should NOT be ignored with the updated gitignore
currentParser.Denies("Modules/Az.Storage/8.1.0/Storage.Autorest/bin/Az.Storage.private.dll").Should().BeFalse("PowerShell module bin files should not be ignored");
currentParser.Denies("Modules/SomeModule/1.0.0/bin/Module.dll").Should().BeFalse("PowerShell module bin files should not be ignored");

// Non-bin files in modules should not be ignored
currentParser.Denies("Modules/Az.Accounts/2.0.0/lib/netstandard2.0/Microsoft.Azure.dll").Should().BeFalse();
}
}
Loading