Refactor `func pack` #4600

aishwaryabh · 2025-08-12T18:30:49Z

Issue describing the changes in this PR

resolves#4593

This issue allows users to run func pack when they want to create a zip file that they can use the azure CLI to deploy. The general syntax of the command is as follows:

func pack [path of folder to pack] [language specific options] [--no-build] [--output]

When the user runs func --help the following is displayed:

Note that func pack will NOT be displayed when the user does func --help until we clean up the CLI and add all the validations for each command when running func pack. This will be done in a future PR

This PR adds the applicable E2E tests for the different scenarios and for each language worker runtime as well.

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes do not need to be backported to a previous version
- Otherwise: Backport tracked by issue/PR #issue_or_pr
My changes should not be added to the release notes for the next release
- Otherwise: I've added my notes to release_notes.md
I have added all required tests (Unit tests, E2E tests)

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs

src/Cli/func/Actions/LocalActions/PackAction/PackHelpers.cs

src/Cli/func/Actions/LocalActions/PackAction/PackOptions.cs

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs

src/Cli/func/Actions/HelpAction.cs

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs

src/Cli/func/Actions/LocalActions/PackAction/NodePackSubcommandAction.cs

src/Cli/func/Actions/LocalActions/PackAction/PythonPackSubcommandAction.cs

test/Cli/Func.E2ETests/Commands/FuncPack/PythonPackTests.cs

…pack command (#4530)" This reverts commit b791c6e.

liliankasem · 2025-08-29T16:32:58Z

release_notes.md

@@ -1,10 +1,9 @@
-# Azure Functions CLI 4.2.2
+# Azure Functions CLI 4.2.3


I think new feature = minor

liliankasem · 2025-08-29T16:54:29Z

src/Cli/func/Common/SecretsManager.cs

        {
+            if (refreshSecrets)


What does refresh secrets have to do with func pack? Does this need to be in this PR?

So in the secret manager, the appsettings are lazy loaded. This works for most scenarios, but it doesn't work for func pack if the user inputs a directory that they are trying to pack, since the worker runtime is determined by this Init action which is called in ConsoleApp. We could switch directories directly before running this action, but the problem is that we still need to store what the value of the current directory is (in case the user doesn't have an ouput directory where they want the zip file to be located). I also don't think it made sense to have a hardcoded scenario for only if it's func pack, switch directories. Does that make sense?

I know that we eventually want to allow all commands to have func <command> <folder path> but I thought this was a bit out of the scope of the PR to modify the Init action to account for this for all of the commands (since we only want this to happen for func pack), so I decided to have this as a workaround.

liliankasem · 2025-08-29T16:55:54Z

src/Cli/func/Actions/LocalActions/PackAction/PythonPackSubcommandAction.cs

+                "When enabled, Core Tools starts a Docker container, builds the app inside that container," +
+                " and creates a ZIP file with all dependencies restored in .python_packages.")


nit: indent desc strings

Suggested change

"When enabled, Core Tools starts a Docker container, builds the app inside that container," +

" and creates a ZIP file with all dependencies restored in .python_packages.")

"When enabled, Core Tools starts a Docker container, builds the app inside that container," +

" and creates a ZIP file with all dependencies restored in .python_packages.")

liliankasem · 2025-08-29T16:56:59Z

src/Cli/func/Actions/LocalActions/PackAction/PowershellPackSubcommandAction.cs

+
+namespace Azure.Functions.Cli.Actions.LocalActions.PackAction
+{
+    [Action(Name = "pack powershell", ParentCommandName = "pack", ShowInHelp = false, HelpText = "Arguments specific to PowerShell apps when running func pack")]


Is this false because there are no custom pwsh args right now? Can we add a comment that mentions that

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs

liliankasem · 2025-08-29T17:01:33Z

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs

+            Parser
+                .Setup<bool>("no-build")
+                .WithDescription("Do not build the project before packaging. Optionally provide a directory when func pack as the first argument that has the build contents." +
+                "Otherwise, default is the current directory.")


If a line is connected to the one above, you should indent to make that clear

Suggested change

"Otherwise, default is the current directory.")

"Otherwise, default is the current directory.")

liliankasem · 2025-08-29T17:07:16Z

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs

+                NoBuild = NoBuild
+            };
+
+            var oldCurrentDirectory = Environment.CurrentDirectory;


originalCurrentDirectory ?

liliankasem · 2025-08-29T17:09:16Z

src/Cli/func/Actions/LocalActions/PackAction/NodePackSubcommandAction.cs

+            EnsureNpmExists();
+
+            // Change to the function app directory for npm operations
+            var previousDirectory = Environment.CurrentDirectory;


Let's be consistent across all the commands on what we're calling this

liliankasem · 2025-08-29T17:14:19Z

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs

+
+                if (string.IsNullOrEmpty(options.FolderPath))
+                {
+                    ColoredConsole.WriteLine(WarningColor("No folder path specified. Using current directory as build output directory."));


For this, can we do more than just defaulting to current? This is probably a good place to check for .props etc.

oo yes that's valid. I can add this scenario

liliankasem reviewed Aug 12, 2025

View reviewed changes

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs Outdated Show resolved Hide resolved

liliankasem reviewed Aug 12, 2025

View reviewed changes

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs Outdated Show resolved Hide resolved

liliankasem reviewed Aug 12, 2025

View reviewed changes

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs Outdated Show resolved Hide resolved

liliankasem reviewed Aug 12, 2025

View reviewed changes

src/Cli/func/Actions/LocalActions/PackAction/DotnetPackSubcommandAction.cs Outdated Show resolved Hide resolved

liliankasem reviewed Aug 12, 2025

View reviewed changes

aishwaryabh marked this pull request as ready for review August 19, 2025 00:27

aishwaryabh requested a review from a team as a code owner August 19, 2025 00:27

aishwaryabh force-pushed the aibhandari/refactor-func-pack branch from 7aa5ae6 to 0a7f737 Compare August 19, 2025 00:45

swapnil-nagar reviewed Aug 19, 2025

View reviewed changes

hallvictoria reviewed Aug 19, 2025

View reviewed changes

aishwaryabh force-pushed the aibhandari/refactor-func-pack branch from f0aba02 to 6b7ed31 Compare August 22, 2025 16:51

aishwaryabh added 13 commits August 29, 2025 08:29

Revert "Add automatic remote build detection for Python apps in func …

987113f

…pack command (#4530)" This reverts commit b791c6e.

testing with dotnet subcommand

56403c9

adding more functionality for func --help to work

8112798

addressing comments for dotnet subcommand

5023671

adding custom subcommand

7efa530

adding additional tests and adding custom handlers project

809c181

changes for getting func pack working

9ded7fc

fixing syntax errors

a4762ed

fixing bugs and adding relevant e2e tests

7046b31

adding unit tests

6174002

fixing e2e test

38a3951

remove pack action from help menu for now

d4c22db

removing extra unneeded files

377294c

aishwaryabh force-pushed the aibhandari/refactor-func-pack branch from 0761d80 to 377294c Compare August 29, 2025 15:32

editing release notes

b47f4bc

hallvictoria approved these changes Aug 29, 2025

View reviewed changes

adding central package mgmt back

49368fa

liliankasem reviewed Aug 29, 2025

View reviewed changes

release_notes.md

@@ -1,10 +1,9 @@

# Azure Functions CLI 4.2.2

# Azure Functions CLI 4.2.3

Copy link

Member

liliankasem Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think new feature = minor

liliankasem reviewed Aug 29, 2025

View reviewed changes

src/Cli/func/Actions/LocalActions/PackAction/PackAction.cs Show resolved Hide resolved

liliankasem reviewed Aug 29, 2025

View reviewed changes

		@@ -1,10 +1,9 @@
		# Azure Functions CLI 4.2.2
		# Azure Functions CLI 4.2.3

		"When enabled, Core Tools starts a Docker container, builds the app inside that container," +
		" and creates a ZIP file with all dependencies restored in .python_packages.")

	"Otherwise, default is the current directory.")
	"Otherwise, default is the current directory.")

Refactor func pack #4600

Are you sure you want to change the base?

Refactor func pack #4600

Uh oh!

Conversation

aishwaryabh commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue describing the changes in this PR

Pull request checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aishwaryabh Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aishwaryabh Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Refactor `func pack` #4600

Refactor `func pack` #4600

aishwaryabh commented Aug 12, 2025 •

edited

Loading

aishwaryabh Aug 29, 2025 •

edited

Loading

aishwaryabh Aug 29, 2025 •

edited

Loading