-
Notifications
You must be signed in to change notification settings - Fork 458
Refactor func pack
#4600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aishwaryabh
wants to merge
15
commits into
main
Choose a base branch
from
aibhandari/refactor-func-pack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor func pack
#4600
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
987113f
Revert "Add automatic remote build detection for Python apps in func …
aishwaryabh 56403c9
testing with dotnet subcommand
aishwaryabh 8112798
adding more functionality for func --help to work
aishwaryabh 5023671
addressing comments for dotnet subcommand
aishwaryabh 7efa530
adding custom subcommand
aishwaryabh 809c181
adding additional tests and adding custom handlers project
aishwaryabh 9ded7fc
changes for getting func pack working
aishwaryabh a4762ed
fixing syntax errors
aishwaryabh 7046b31
fixing bugs and adding relevant e2e tests
aishwaryabh 6174002
adding unit tests
aishwaryabh 38a3951
fixing e2e test
aishwaryabh d4c22db
remove pack action from help menu for now
aishwaryabh 377294c
removing extra unneeded files
aishwaryabh b47f4bc
editing release notes
aishwaryabh 49368fa
adding central package mgmt back
aishwaryabh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
# Azure Functions CLI 4.2.2 | ||
# Azure Functions CLI 4.2.3 | ||
|
||
#### Host Version | ||
|
||
- Host Version: 4.1041.200 | ||
- In-Proc Host Version: 4.41.100 (4.841.100, 4.641.100) | ||
|
||
#### Changes | ||
|
||
- Fix .NET template install bug (#4612) | ||
- Add `func pack` functionality to other languages (#4600) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
src/Cli/func/Actions/LocalActions/PackAction/CustomPackSubcommandAction.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
||
using Azure.Functions.Cli.Interfaces; | ||
using Fclp; | ||
|
||
namespace Azure.Functions.Cli.Actions.LocalActions.PackAction | ||
{ | ||
[Action(Name = "pack custom", ParentCommandName = "pack", ShowInHelp = false, HelpText = "Arguments specific to custom worker runtime apps when running func pack")] | ||
internal class CustomPackSubcommandAction : PackSubcommandAction | ||
{ | ||
public override ICommandLineParserResult ParseArgs(string[] args) | ||
{ | ||
return base.ParseArgs(args); | ||
} | ||
|
||
public async Task RunAsync(PackOptions packOptions) | ||
{ | ||
await ExecuteAsync(packOptions); | ||
} | ||
|
||
protected override Task<string> GetPackingRootAsync(string functionAppRoot, PackOptions options) | ||
{ | ||
// Custom worker packs from the function app root without extra steps | ||
return Task.FromResult(functionAppRoot); | ||
} | ||
|
||
public override Task RunAsync() | ||
{ | ||
// Keep this since this subcommand is not meant to be run directly. | ||
return Task.CompletedTask; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think new feature = minor