-
Notifications
You must be signed in to change notification settings - Fork 2
Add invocation id to module private data and add a Get-CurrentActivityForInvocation cmdlet #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/AzureFunctions.PowerShell.OpenTelemetry.SDK/Traces/GetCurrentActivityForInvocation.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// | ||
// Copyright (c) Microsoft. All rights reserved. | ||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
// | ||
|
||
using System.Management.Automation; | ||
using OpenTelemetryEngine.Traces; | ||
using OpenTelemetryEngine.ResponseObjects; | ||
|
||
namespace AzureFunctions.PowerShell.OpenTelemetry.SDK | ||
{ | ||
/// <summary> | ||
/// This cmdlet is used to start an OpenTelemetry invocation. | ||
/// Currently, that just means starting a (hidden) span which is a copy of the host span. | ||
/// This allows all new spans created by the user or by dependent modules to link back to the host span using TraceParent. | ||
/// </summary> | ||
[Cmdlet(VerbsCommon.Get, "CurrentActivityForInvocation")] | ||
[OutputType(typeof(GetActivityResponse))] | ||
public class GetCurrentActivityForInvocation : PSCmdlet | ||
{ | ||
/// <summary> | ||
/// InvocationId for the current invocation | ||
/// </summary> | ||
[Parameter(Mandatory = true)] | ||
public string InvocationId { get; set; } = string.Empty; | ||
|
||
// This method will be called for each input received from the pipeline to this cmdlet; if no input is received, this method is not called | ||
protected override void ProcessRecord() | ||
{ | ||
WriteObject(FunctionsActivityBuilder.GetActivityForInvocation(InvocationId)); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
src/OpenTelemetryEngine/ResponseObjects/GetActivityResponse.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
using System.Diagnostics; | ||
|
||
namespace OpenTelemetryEngine.ResponseObjects | ||
{ | ||
public class GetActivityResponse | ||
AnatoliB marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
public Activity? activity; | ||
|
||
public GetActivityResponse(Activity? activity) | ||
{ | ||
this.activity = activity; | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.