Skip to content

Update opentelemetry(_sdk) to 0.27, tracing-opentelemetry 0.28, fix build issues #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Update opentelemetry(_sdk) to 0.27, tracing-opentelemetry 0.28, fix build issues #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ff2149
Update opentelemetry_sdk requirement from 0.26 to 0.27
dependabot[bot] Feb 3, 2025
5c33363
Update opentelemetry requirement from 0.26 to 0.27
dependabot[bot] Feb 3, 2025
3318eb7
Update tracing-opentelemetry requirement from 0.27 to 0.28
dependabot[bot] Feb 3, 2025
cf8feba
Do not use with_config for opentelemetry 0.27
dongsupark Feb 4, 2025
b1262ba
Merge branch 'main' into dongsu/opentelemetry-0.27
dongsupark Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ tracing = "0.1.40"
clap = { version = "4.5.21", features = ["derive", "cargo", "env"] }
sysinfo = "0.33"
tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
opentelemetry = "0.26"
opentelemetry_sdk = "0.26"
tracing-opentelemetry = "0.27"
opentelemetry = "0.27"
opentelemetry_sdk = "0.27"
tracing-opentelemetry = "0.28"
uuid = { version = "1.2", features = ["v4"] }
chrono = "0.4"

Expand Down
8 changes: 4 additions & 4 deletions src/logging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

use opentelemetry::{global, trace::TracerProvider};
use opentelemetry_sdk::trace::{
self as sdktrace, Config, Sampler, TracerProvider as SdkTracerProvider,
self as sdktrace, Sampler, TracerProvider as SdkTracerProvider,
};
use tracing::{event, Level};
use tracing_opentelemetry::OpenTelemetryLayer;
Expand All @@ -15,9 +15,9 @@ use tracing_subscriber::{
use crate::kvp::EmitKVPLayer;

pub fn initialize_tracing() -> sdktrace::Tracer {
let config = Config::default().with_sampler(Sampler::AlwaysOn);

let provider = SdkTracerProvider::builder().with_config(config).build();
let provider = SdkTracerProvider::builder()
.with_sampler(Sampler::AlwaysOn)
.build();

global::set_tracer_provider(provider.clone());
provider.tracer("azure-kvp")
Expand Down