Update opentelemetry(_sdk) to 0.27, tracing-opentelemetry 0.28, fix build issues #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry_sdk-0.26.0...opentelemetry_sdk-0.27.1) --- updated-dependencies: - dependency-name: opentelemetry_sdk dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.26.0...opentelemetry-0.27.1) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [tracing-opentelemetry](https://github.com/tokio-rs/tracing-opentelemetry) to permit the latest version. - [Release notes](https://github.com/tokio-rs/tracing-opentelemetry/releases) - [Changelog](https://github.com/tokio-rs/tracing-opentelemetry/blob/v0.1.x/CHANGELOG.md) - [Commits](tokio-rs/tracing-opentelemetry@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: tracing-opentelemetry dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
As opentelemetry 0.27 or newer does not have a method `with_config` for TraceBuilder, it is necessary to call `with_sampler` directly from TraceBuilder without `with_config`. Needed to fix build issues with opentelemetry(_sdk) 0.27 or newer as well as tracing_opentelemetry 0.28 or newer. See also open-telemetry/opentelemetry-rust#2303.
This was referenced Feb 4, 2025
dongsupark
added
dependencies
Contributor
|
At first glance, this looks good to me -- but let me run it through and try to build an image with this to make sure the KVP still works as expected. I've found upgrading open-telemetry to sometimes break the functionality so with that change and with_config deprecated. testing seems necessary. If the image succeeds w KVP sent to HyperV, I'll approve. Thanks for taking care of this!! |
jeremycline
reviewed
Feb 4, 2025
Member
jeremycline
left a comment
jeremycline
left a comment
There was a problem hiding this comment.
Everything looks good to me, but I'll defer to @peytonr18 and the test results
github-project-automation
bot
moved this to Backlog
in Azure-init x Afterburn integration 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
opentelemetry&opentelemetry_sdkto 0.27.1,tracing-opentelemetryto 0.28.(Replaces #158, #159, #160)
Fix build issues with opentelemetry(_sdk) 0.27 or newer as well as tracing-opentelemetry 0.28 or newer. As opentelemetry 0.27 or newer does not have a method
with_configfor TraceBuilder, it is necessary to callwith_samplerdirectly from TraceBuilder withoutwith_config.See also open-telemetry/opentelemetry-rust#2303.