[Az.Batch] Adds Get-AzBatchSupportedVirtualMachineSku, Get-AzBatchTaskSlotCount, and Get-AzBatchComputeNodeExtension commands #16459

paterasMSFT · 2021-11-22T18:08:54Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1133
- the markdown help files have been regenerated using the commands listed here

src/Batch/Batch/Tasks/GetBatchTaskSlotCountCommand.cs

isra-fel

Hi Mike @paterasMSFT , as this is the major release of Az, we are composing a migration guide for customers. Would you mind fill in a table like this about the breaking changes in Az.Batch module? Thanks (You can do that after the PR is merged, as that is of higher priority).

cmdlet	breaking change	old usage	new usage

src/Batch/Batch/ChangeLog.md

src/Accounts/Accounts/AzureRmAlias/Mappings.json

src/Batch/Batch/Properties/Resources.resx

src/Batch/Batch/help/New-AzBatchPool.md

isra-fel · 2021-11-30T08:57:31Z

Changed base branch to release-2021-12-07 as we have begun the release process

isra-fel · 2021-12-01T02:15:26Z

Hey Mike there are two test cases failing. Please check the pipeline logs for details.

src/Batch/Batch/help/New-AzBatchPool.md

tools/StaticAnalysis/Exceptions/Az.Batch/BreakingChangeIssues.csv

BethanyZhou

Please let me know if this PR is ready to be reviewed again by adding 'needs-review' label and removing needs-revision .

BethanyZhou · 2022-03-15T01:04:05Z

src/Batch/Batch.Test/ScenarioTests/CertificateTests.ps1


    # Verify the cert went back to the active state
-    $filter = "state eq 'active'"
+    $filter = "state eq 'active'";


Suggested change

$filter = "state eq 'active'";

$filter = "state eq 'active'"

BethanyZhou · 2022-03-15T01:04:58Z

src/Batch/Batch/ChangeLog.md

 ## Upcoming Release

+* Updated Az.Batch to use `Microsoft.Azure.Batch` SDK version 15.3.0
+  - Add ability to assign user-assigned managed identities to `PSCloudPool`. These identities will be made available on each node in the pool, and can be used to access various resources.


Suggested change

- Add ability to assign user-assigned managed identities to `PSCloudPool`. These identities will be made available on each node in the pool, and can be used to access various resources.

- Added ability to assign user-assigned managed identities to `PSCloudPool`. These identities will be made available on each node in the pool, and can be used to access various resources.

BethanyZhou · 2022-03-15T01:05:59Z

src/Batch/Batch/ComputeNodeExtensions/GetBatchComputeNodeExtensionCommand.cs

+        [Parameter(ParameterSetName = Constants.IdParameterSet)]
+        [Parameter(ParameterSetName = Constants.ParentObjectParameterSet)]
+        [ValidateNotNullOrEmpty]
+        public string Select { get; set; }
+
+
+        [Parameter(ParameterSetName = Constants.IdParameterSet)]
+        [Parameter(ParameterSetName = Constants.ParentObjectParameterSet)]
+        [ValidateNotNullOrEmpty]
+        public int MaxCount
+        {
+            get { return maxCount; }
+            set { maxCount = value; }
+        }


Please add help message for all parameters.

Fixed nullable reference types Fixed types

Generated models Generated models

isra-fel · 2022-04-14T06:44:45Z

/azp run azure-powershell - powershell-core

azure-pipelines · 2022-04-14T06:44:55Z

Azure Pipelines successfully started running 1 pipeline(s).

isra-fel · 2022-04-14T12:59:56Z

/azp run azure-powershell - security-tools

azure-pipelines · 2022-04-14T13:00:22Z

Azure Pipelines successfully started running 1 pipeline(s).

comments resolved

paterasMSFT mentioned this pull request Nov 22, 2021

[DRAFT] Batch Update #15770

Closed

8 tasks

paterasMSFT added this to the Nov 2021 (2021-12-07) ❗ Breaking change release ❗ milestone Nov 22, 2021

paterasMSFT changed the title ~~Mipatera/batchrelease~~ [Az.Batch] Adds Get-AzBatchSupportedVirtualMachineSku and Get-AzBatchTaskSlotCount Nov 22, 2021

paterasMSFT force-pushed the mipatera/batchrelease branch from fd34320 to 04f83a1 Compare November 22, 2021 18:17

paterasMSFT self-assigned this Nov 22, 2021

paterasMSFT force-pushed the mipatera/batchrelease branch 3 times, most recently from 12d416c to 186a53c Compare November 22, 2021 19:02

isra-fel added the Contains Breaking Change This PR contains breaking change label Nov 23, 2021

paterasMSFT marked this pull request as ready for review November 23, 2021 13:50

paterasMSFT force-pushed the mipatera/batchrelease branch from 8a34e4e to 31ccbcf Compare November 24, 2021 17:31

isra-fel requested changes Nov 25, 2021

View reviewed changes

src/Batch/Batch/Tasks/GetBatchTaskSlotCountCommand.cs Outdated Show resolved Hide resolved

isra-fel requested changes Nov 30, 2021

View reviewed changes

isra-fel added the needs-revision label Nov 30, 2021

isra-fel changed the base branch from main to release-2021-12-07 November 30, 2021 08:56

paterasMSFT force-pushed the mipatera/batchrelease branch from ebc2971 to 26fd415 Compare November 30, 2021 16:57

paterasMSFT force-pushed the mipatera/batchrelease branch from 26fd415 to 4962a7e Compare December 3, 2021 17:41

paterasMSFT requested review from Sandido, bilaakpan-ms, grizzlytheodore and haagha as code owners December 3, 2021 17:41

paterasMSFT force-pushed the mipatera/batchrelease branch 2 times, most recently from 3150fb6 to d3b6855 Compare December 3, 2021 18:41

msJinLei changed the base branch from release-2021-12-07 to main December 7, 2021 03:27

msJinLei suggested changes Dec 7, 2021

View reviewed changes

src/Batch/Batch/help/New-AzBatchPool.md Outdated Show resolved Hide resolved

tools/StaticAnalysis/Exceptions/Az.Batch/BreakingChangeIssues.csv Outdated Show resolved Hide resolved

paterasMSFT force-pushed the mipatera/batchrelease branch from d3b6855 to 0edddec Compare December 7, 2021 19:24

paterasMSFT requested review from isra-fel and msJinLei December 8, 2021 15:34

paterasMSFT force-pushed the mipatera/batchrelease branch from 7b6c8af to 012299b Compare March 14, 2022 16:18

BethanyZhou reviewed Mar 15, 2022

View reviewed changes

paterasMSFT added 3 commits March 21, 2022 17:26

Moved previously generated file out of generated folder

70fd3af

Cleanup and add ability to wrap Microsoft.Azure.Batch.Common enums.

cf35e24

Regenerated models

a64f159

BethanyZhou modified the milestones: Mar 2022 (2022-04-05), Backlog Mar 28, 2022

isra-fel added needs-review and removed needs-revision labels Mar 31, 2022

isra-fel assigned isra-fel and unassigned BethanyZhou Mar 31, 2022

paterasMSFT added 3 commits March 31, 2022 17:22

Cleanup and add ability to wrap Microsoft.Azure.Batch.Common enums.

b4caaa9

Fixed nullable reference types Fixed types

Regenerated models

d18179a

Generated models Generated models

Fixed enum types

e6292a9

isra-fel added Waiting for CI and removed needs-review labels Apr 14, 2022

isra-fel approved these changes Apr 15, 2022

View reviewed changes

isra-fel merged commit 22fc904 into Azure:main Apr 15, 2022

	- Add ability to assign user-assigned managed identities to `PSCloudPool`. These identities will be made available on each node in the pool, and can be used to access various resources.
	- Added ability to assign user-assigned managed identities to `PSCloudPool`. These identities will be made available on each node in the pool, and can be used to access various resources.

[Az.Batch] Adds Get-AzBatchSupportedVirtualMachineSku, Get-AzBatchTaskSlotCount, and Get-AzBatchComputeNodeExtension commands #16459

[Az.Batch] Adds Get-AzBatchSupportedVirtualMachineSku, Get-AzBatchTaskSlotCount, and Get-AzBatchComputeNodeExtension commands #16459

Uh oh!

Conversation

paterasMSFT commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

isra-fel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Nov 30, 2021

Uh oh!

isra-fel commented Dec 1, 2021

Uh oh!

Uh oh!

Uh oh!

BethanyZhou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BethanyZhou Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

BethanyZhou Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

BethanyZhou Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

isra-fel commented Apr 14, 2022

Uh oh!

azure-pipelines bot commented Apr 14, 2022

Uh oh!

isra-fel commented Apr 14, 2022

Uh oh!

azure-pipelines bot commented Apr 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

paterasMSFT commented Nov 22, 2021 •

edited

Loading

isra-fel left a comment •

edited

Loading

BethanyZhou left a comment •

edited

Loading