[Az.Functions] Fix cloud portability by using dynamic endpoints for storage #29035

Francisco-Gamino · 2026-01-07T21:30:57Z

Description

This PR fixes issues #29034 where New-AzFunctionApp fails in non-public Azure clouds due to hardcoded endpoint values for storage connection strings. The change ensure full cloud portability across Azure Public and custom cloud environments.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…construction

azure-client-tools-bot-prd · 2026-01-07T21:31:00Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Francisco-Gamino · 2026-01-07T21:32:52Z

/cc @amamounelsayed, @castrodd, @isra-fel, @dolauli

isra-fel · 2026-01-07T21:38:27Z

/azp run

azure-pipelines · 2026-01-07T21:38:41Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

This pull request addresses cloud portability issues in Az.Functions by replacing hardcoded endpoint values with dynamic endpoint resolution for storage connection strings and Application Insights. The changes ensure that New-AzFunctionApp can work correctly across Azure Public Cloud and custom/sovereign Azure cloud environments.

Key Changes

Modified GetEndpointSuffix function to use StorageEndpointSuffix property from Azure context instead of hardcoded switch statement
Updated Application Insights endpoint construction in WhatIf scenario to dynamically retrieve endpoint from Azure context

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Functions/Functions.Autorest/custom/HelperFunctions.ps1	Refactored `GetEndpointSuffix` to use `StorageEndpointSuffix` property from Azure environment context, replacing hardcoded endpoint mappings for different cloud environments
src/Functions/Functions.Autorest/custom/New-AzFunctionApp.ps1	Updated WhatIf scenario to dynamically construct Application Insights endpoints using `AzureApplicationInsightsEndpointResourceId` from Azure environment context instead of hardcoded "applicationinsights.azure.com" domain

src/Functions/Functions.Autorest/custom/New-AzFunctionApp.ps1

Francisco-Gamino · 2026-01-07T21:39:53Z

@wyunchi-ms - Would it be possible to include this fix in the Az 15.2.0 release? Thank you.

…nt property

isra-fel · 2026-01-07T22:08:31Z

/azp run

azure-pipelines · 2026-01-07T22:08:46Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel

LGTM but please update the ChangeLog.md file

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Francisco-Gamino · 2026-01-08T00:23:13Z

@isra-fel - Thank you for the review. The change log has been updated.

isra-fel · 2026-01-08T00:31:39Z

LGTM

isra-fel · 2026-01-08T00:38:22Z

/azp run

azure-pipelines · 2026-01-08T00:38:37Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2026-01-12T03:28:42Z

Hi @Francisco-Gamino , the code freeze date is Jan 6, so we cannot accept this PR in this release. I will re-target this to main branch. Let's release it in the next release.

vidai-msft · 2026-01-13T04:38:54Z

src/KeyVault/KeyVault/SecurityDomain/Models/CertKey.cs

        public X509Certificate2 GetCert() { return _cert; }

-        static RSAParameters RsaParamsFromPem(string path, string password)  // CodeQL [SM02205] BouncyCastle is the only API available because we need to be at netstandard2.0
+        static RSAParameters RsaParamsFromPem(string path, string password)  //CodeQL [SM02205] BouncyCastle is the only API available because we need to be at netstandard2.0


Please revert the change here.

vidai-msft · 2026-01-13T04:39:16Z

src/Functions/Functions/ChangeLog.md

 -->
 ## Upcoming Release

+* Fix cloud portability by using dynamic endpoints for storage [#29034]


Suggested change

* Fix cloud portability by using dynamic endpoints for storage [#29034]

* Fixed cloud portability by using dynamic endpoints for storage [#29034]

github-actions · 2026-01-13T04:40:23Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

isra-fel · 2026-01-16T18:38:59Z

/azp run

azure-pipelines · 2026-01-16T18:39:14Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-16T18:40:36Z

src/Functions/Functions/ChangeLog.md

 -->
 ## Upcoming Release

+* Fixed cloud portability by using dynamic endpoints for storage [#29034]


The changelog entry could be more descriptive for users. Consider expanding it to explain the impact and what specific issue was fixed. For example: "Fixed 'New-AzFunctionApp' cmdlet to work in non-public Azure clouds by dynamically retrieving storage endpoints instead of using hardcoded values. This enables full cloud portability across Azure Public, Government, China, and custom cloud environments."

Copilot · 2026-01-16T18:40:36Z

src/Functions/Functions.Autorest/custom/HelperFunctions.ps1

+    $storageEndpointSuffix = (Get-AzContext).Environment.StorageEndpointSuffix



The function could throw a null reference exception if Get-AzContext returns null. Consider adding error handling to check if the context exists before accessing its properties. For example: '$context = Get-AzContext; if ($null -eq $context) { return '' }; $storageEndpointSuffix = $context.Environment.StorageEndpointSuffix'

Suggested change

$storageEndpointSuffix = (Get-AzContext).Environment.StorageEndpointSuffix

$context = Get-AzContext

if ($null -eq $context -or $null -eq $context.Environment)

{

return ''

}

$storageEndpointSuffix = $context.Environment.StorageEndpointSuffix

Francisco-Gamino added 2 commits January 7, 2026 10:27

Use StorageEndpointSuffix from context for dynamic connection string …

0e0c839

…construction

Use dynamic cloud endpoints for Application Insights connection strings

b0fbd66

Copilot AI review requested due to automatic review settings January 7, 2026 21:30

Copilot started reviewing on behalf of Francisco-Gamino January 7, 2026 21:33 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

src/Functions/Functions.Autorest/custom/New-AzFunctionApp.ps1 Outdated Show resolved Hide resolved

Revert Application Insights WhatIf change due to missing cloud endpoi…

6bc4db5

…nt property

Francisco-Gamino requested a review from wyunchi-ms January 7, 2026 21:55

Francisco-Gamino changed the title ~~[Az.Functions] Fix cloud portability by using dynamic endpoints for storage and Application Insights~~ [Az.Functions] Fix cloud portability by using dynamic endpoints for storage Jan 7, 2026

isra-fel reviewed Jan 7, 2026

View reviewed changes

Update change log

0f0760a

Copilot AI review requested due to automatic review settings January 8, 2026 00:15

Copilot started reviewing on behalf of Francisco-Gamino January 8, 2026 00:17 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

isra-fel changed the base branch from main to release-2026-01-13 January 8, 2026 00:29

wyunchi-ms changed the base branch from release-2026-01-13 to main January 12, 2026 03:28

vidai-msft requested changes Jan 13, 2026

View reviewed changes

vidai-msft added the needs-revision label Jan 13, 2026

Fix change log entry

69366db

Copilot AI review requested due to automatic review settings January 16, 2026 18:34

Francisco-Gamino force-pushed the functions-fix-connectionstring-endpointsuffix branch from 092b548 to 69366db Compare January 16, 2026 18:34

Copilot started reviewing on behalf of Francisco-Gamino January 16, 2026 18:37 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

	* Fix cloud portability by using dynamic endpoints for storage [#29034]
	* Fixed cloud portability by using dynamic endpoints for storage [#29034]

		$storageEndpointSuffix = (Get-AzContext).Environment.StorageEndpointSuffix

-    $storageEndpointSuffix = (Get-AzContext).Environment.StorageEndpointSuffix
+    $context = Get-AzContext
+    if ($null -eq $context -or $null -eq $context.Environment)
+    {
+        return ''
+    }
+    $storageEndpointSuffix = $context.Environment.StorageEndpointSuffix

[Az.Functions] Fix cloud portability by using dynamic endpoints for storage #29035

Are you sure you want to change the base?

[Az.Functions] Fix cloud portability by using dynamic endpoints for storage #29035

Conversation

Francisco-Gamino commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jan 7, 2026

Uh oh!

Francisco-Gamino commented Jan 7, 2026

Uh oh!

isra-fel commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Francisco-Gamino commented Jan 7, 2026

Uh oh!

isra-fel commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Francisco-Gamino commented Jan 8, 2026

Uh oh!

isra-fel commented Jan 8, 2026

Uh oh!

isra-fel commented Jan 8, 2026

Uh oh!

azure-pipelines bot commented Jan 8, 2026

Uh oh!

wyunchi-ms commented Jan 12, 2026

Uh oh!

vidai-msft Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

vidai-msft Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

isra-fel commented Jan 16, 2026

Uh oh!

azure-pipelines bot commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Francisco-Gamino commented Jan 7, 2026 •

edited

Loading