Skip to content

Conversation

diwudd
Copy link
Contributor

@diwudd diwudd commented Jun 9, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • [ X Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @diwudd Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 9, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 36 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267
    ⚠️ R4021 - DescriptionAndTitleMissing 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L39
    ⚠️ R1003 - ListInOperationName Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Features/stable/2021-07-01/features.json#L44
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 19 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L63:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L102:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L148:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L201:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L251:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Features/stable/2021-07-01/features.json#L301:11
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Features/stable/2021-07-01/features.json#L59:13
    Old: Microsoft.Features/stable/2015-12-01/features.json#L59:13
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Features/stable/2021-07-01/features.json#L369:9
    Old: Microsoft.Features/stable/2015-12-01/features.json#L330:9
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Features/stable/2021-07-01/features.json#L98:13
    Old: Microsoft.Features/stable/2015-12-01/features.json#L92:13
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Features/stable/2021-07-01/features.json#L349:11
    Old: Microsoft.Features/stable/2015-12-01/features.json#L310:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2017-05",
    "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
    ⚠️ Modeler/MissingType "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2016-09",
    "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
    ⚠️ Modeler/MissingType "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2016-07",
    "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-07-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
    ⚠️ Modeler/MissingType "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2016-02",
    "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-02-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
    ⚠️ Modeler/MissingType "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2015-11",
    "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2015-11-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2021-04",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2021-04",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-features-2021-07",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-features-2021-07",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"resources/resource-manager/readme.md",
    "tag":"profile-hybrid-2019-03-01",
    "details":"Duplicate Schema named Operation -- properties.display.$ref: undefined => "#/components/schemas/schemas:166" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"resources/resource-manager/readme.md",
    "tag":"profile-hybrid-2019-03-01",
    "details":"Duplicate Schema named Operation-display -- properties.provider.description: undefined => "Service provider: Microsoft.Resources",
    properties.description: undefined => "$ref":"#/components/schemas/schemas:170",
    "description":"Description of the operation." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"resources/resource-manager/readme.md",
    "tag":"profile-hybrid-2019-03-01",
    "details":"Duplicate Schema named OperationListResult -- properties.value.$ref: undefined => "#/components/schemas/schemas:172",
    properties.value.description: undefined => "List of Microsoft.Resources operations." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"resources/resource-manager/readme.md",
    "tag":"profile-hybrid-2019-03-01",
    "details":"Duplicate Schema named ErrorResponse -- properties.error: "$ref":"#/components/schemas/schemas:161",
    "description":"The error details." =>,
    properties.code: undefined => "$ref":"#/components/schemas/schemas:539",
    "description":"The error code.",
    "readOnly":true,
    properties.message: undefined => "$ref":"#/components/schemas/schemas:540",
    "description":"The error message.",
    "readOnly":true,
    properties.target: undefined => "$ref":"#/components/schemas/schemas:541",
    "description":"The error target.",
    "readOnly":true,
    properties.details: undefined => "$ref":"#/components/schemas/schemas:542",
    "description":"The error details.",
    "readOnly":true,
    properties.additionalInfo: undefined => "$ref":"#/components/schemas/schemas:543",
    "description":"The error additional info.",
    "readOnly":true,
    title: undefined => "Error Response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"profile-hybrid-2019-03-01",
    "details":"Error: Plugin prechecker reported failure."
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-resources-2021-04",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-policy-2020-09",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-policy-2020-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-preview-2020-08",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"resources/resource-manager/readme.md",
    "tag":"package-preview-2020-08",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 9, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-resource - 18.0.0
    ️✔️azure-sdk-for-go - resources/mgmt/2021-01-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2021-01-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2020-10-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2020-06-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-11-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-10-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-09-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-07-01/managedapplications - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-07-01/features - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-06-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-06-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-05-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-03-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2019-01-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-06-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-06-01/managedapplications - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-05-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-05-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-03-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2018-02-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2017-09-01/managedapplications - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2017-05-10/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-12-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/locks - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/links - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-07-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-06-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-04-01/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2016-02-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2015-12-01/features - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2015-11-01/subscriptions - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2015-11-01/resources - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2015-01-01/locks - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/resources/mgmt/2020-09-01-preview/policy - Approved - v55.3.0
    azure-sdk-for-go - preview/resources/mgmt/2020-03-01-preview/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/resources/mgmt/2019-06-01-preview/templatespecs - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/resources/mgmt/2017-06-01-preview/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/resources/mgmt/2016-09-01-preview/managedapplications - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/resources/mgmt/2015-10-01-preview/policy - Approved - v55.3.0
    ️✔️azure-sdk-for-go - resources/mgmt/2021-07-01/features - Approved - v55.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 91ac145. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-30 07:22:05 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resources-generated"
      cmderr	[generate.py] 2021-06-30 07:22:05 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-06-30 07:22:05 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resources/azure-resourcemanager-resources-generated --java.namespace=com.azure.resourcemanager.resources.generated --tag=package-resources-2021-04  --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [POM][Skip] pom already has module azure-resourcemanager-resources-generated
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-30 07:22:44 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-resources-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-30 07:24:17 DEBUG Got artifact_id: azure-resourcemanager-resources-generated
      cmderr	[Inst] 2021-06-30 07:24:17 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-30 07:24:17 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-30 07:24:17 DEBUG Match jar package: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-30 07:24:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14736/azure-sdk-for-java/azure-resourcemanager-resources-generated/azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resources-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resources-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91ac145. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️resources/mgmt/2021-07-01/features [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️resources/mgmt/2021-01-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2021-01-01/resources [View full logs
      info	[Changelog] This is a new package
    • ️✔️resources/mgmt/2020-10-01/resources [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2020-06-01/resources [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-11-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-10-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2019-09-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-07-01/managedapplications [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-07-01/features [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2019-06-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-06-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2019-05-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2019-03-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2019-01-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2018-06-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2018-06-01/managedapplications [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2018-05-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2018-05-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2018-03-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2018-02-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2017-09-01/managedapplications [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2017-05-10/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2016-12-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2016-09-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2016-09-01/locks [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2016-09-01/links [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2016-07-01/resources [View full logs
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️resources/mgmt/2016-06-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2016-04-01/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2016-02-01/resources [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2015-12-01/features [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2015-11-01/subscriptions [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2015-11-01/resources [View full logs
      info	[Changelog] No exported changes
    • ️✔️resources/mgmt/2015-01-01/locks [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resources/mgmt/2020-09-01-preview/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resources/mgmt/2020-03-01-preview/policy [View full logsBreaking Change Detected
      Only show 3 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] Total 64 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️preview/resources/mgmt/2019-06-01-preview/templatespecs [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resources/mgmt/2017-06-01-preview/policy [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resources/mgmt/2016-09-01-preview/managedapplications [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/resources/mgmt/2015-10-01-preview/policy [View full logs
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91ac145. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md
    • ️✔️@azure/arm-features [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/featureClient.js → ./dist/arm-features.js...
      cmderr	[npmPack] created ./dist/arm-features.js in 185ms
    • ️✔️@azure/arm-links [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js...
      cmderr	[npmPack] created ./dist/arm-links.js in 164ms
    • ️✔️@azure/arm-locks [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js...
      cmderr	[npmPack] created ./dist/arm-locks.js in 202ms
    • ️✔️@azure/arm-managedapplications [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js...
      cmderr	[npmPack] created ./dist/arm-managedapplications.js in 270ms
    • ️✔️@azure/arm-policy [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/policyClient.js → ./dist/arm-policy.js...
      cmderr	[npmPack] created ./dist/arm-policy.js in 339ms
    • ️✔️@azure/arm-resources [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js...
      cmderr	[npmPack] created ./dist/arm-resources.js in 508ms
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from 91ac145. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2742) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2742) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2742) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      cmderr	[generateScript.sh] (node:2742) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
      cmderr	[generateScript.sh] (node:2742) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
      warn	No file changes detected after generation
      cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
    • ️✔️resources [View full logs
    • ️✔️resources [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		resources
      error		resources
    Posted by Swagger Pipeline | How to fix these errors?

    "subscriptionId": "00000000-1111-2222-3333-444444444444",
    "providerNamespace": "subscriptionFeatureRegistrationGroupTestRG",
    "featureName": "testFeature",
    "api-version": "2020-09-01"
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @diwudd and @ifeoluwaokunoren - Please update the API version in all the example files to new api version 2021-07-01?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Otherwise changes LGTM. I will signoff once you update the api version in all example files.

    @RamyasreeChakka RamyasreeChakka added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 22, 2021
    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jun 23, 2021 via email

    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 23, 2021
    @raych1
    Copy link
    Member

    raych1 commented Jun 23, 2021

    @ArcturusZhang @msyyc , can you have a look at the potential SDK breaking change ?

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 24, 2021
    @msyyc
    Copy link
    Member

    msyyc commented Jun 25, 2021

    For python, the breaking change is caused by previous PR, not this one.

    @raych1 raych1 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2021
    @raych1
    Copy link
    Member

    raych1 commented Jun 25, 2021

    @diwudd , is this PR ready to merge?

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jun 25, 2021 via email

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jun 28, 2021 via email

    @raych1 raych1 merged commit 91ac145 into Azure:master Jun 30, 2021
    This was referenced Jun 30, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants