-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Microsoft.Features: Add new API version 2021-07-01 #14736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @diwudd Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 19 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-07-01/features.json compared with base:stable/2015-12-01/features.json
Only 10 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
- resources/resource-manager/readme.md#package-resources-2021-04
- resources/resource-manager/readme.md#package-policy-2020-09
- resources/resource-manager/readme.md#package-preview-2020-08
- resources/resource-manager/readme.md#package-subscriptions-2021-01
- resources/resource-manager/readme.md#package-deploymentscripts-2020-10
- resources/resource-manager/readme.md#package-deploymentscripts-2019-10-preview
- resources/resource-manager/readme.md#package-features-2015-12
- resources/resource-manager/readme.md#package-locks-2016-09
- resources/resource-manager/readme.md#package-locks-2015-01
- resources/resource-manager/readme.md#package-policy-2020-03
- resources/resource-manager/readme.md#package-policy-2019-09
- resources/resource-manager/readme.md#package-policy-2019-06
- resources/resource-manager/readme.md#package-policy-2019-01
- resources/resource-manager/readme.md#package-policy-2018-05
- resources/resource-manager/readme.md#package-policy-2018-03
- resources/resource-manager/readme.md#package-policy-2017-06
- resources/resource-manager/readme.md#package-pure-policy-2017-06
- resources/resource-manager/readme.md#package-templatespecs-2021-05
- resources/resource-manager/readme.md#package-templatespecs-2021-03-preview
- resources/resource-manager/readme.md#package-templatespecs-2019-06-preview
- resources/resource-manager/readme.md#package-policy-2016-12
- resources/resource-manager/readme.md#package-policy-2016-04
- resources/resource-manager/readme.md#package-policy-2015-10
- resources/resource-manager/readme.md#package-resources-2021-01
- resources/resource-manager/readme.md#package-resources-2020-10
- resources/resource-manager/readme.md#package-resources-2020-08
- resources/resource-manager/readme.md#package-resources-2020-06
- resources/resource-manager/readme.md#package-resources-2019-10
- resources/resource-manager/readme.md#package-resources-2019-08
- resources/resource-manager/readme.md#package-resources-2019-07
- resources/resource-manager/readme.md#package-resources-2019-0510
- resources/resource-manager/readme.md#package-resources-2019-05
- resources/resource-manager/readme.md#package-resources-2019-03
- resources/resource-manager/readme.md#package-resources-2018-05
- resources/resource-manager/readme.md#package-resources-2018-02
- resources/resource-manager/readme.md#package-resources-2017-05
- resources/resource-manager/readme.md#package-resources-2016-09
- resources/resource-manager/readme.md#package-resources-2016-07
- resources/resource-manager/readme.md#package-resources-2016-02
- resources/resource-manager/readme.md#package-resources-2015-11
- resources/resource-manager/readme.md#package-subscriptions-2020-01
- resources/resource-manager/readme.md#package-subscriptions-2019-11
- resources/resource-manager/readme.md#package-subscriptions-2019-06
- resources/resource-manager/readme.md#package-subscriptions-2018-06
- resources/resource-manager/readme.md#package-subscriptions-2016-06
- resources/resource-manager/readme.md#package-subscriptions-2015-11
- resources/resource-manager/readme.md#package-links-2016-09
- resources/resource-manager/readme.md#package-managedapplications-2019-07
- resources/resource-manager/readme.md#package-managedapplications-2018-06
- resources/resource-manager/readme.md#package-managedapplications-2017-09
- resources/resource-manager/readme.md#package-managedapplications-2016-09
- resources/resource-manager/readme.md#profile-hybrid-2019-03-01
- resources/resource-manager/readme.md#package-features-2021-07
Rule | Message |
---|---|
"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2017-05", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage" |
|
"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-09", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage" |
|
"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-07", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-07-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage" |
|
"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-02", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-02-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage" |
|
"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2015-11", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2015-11-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage" |
|
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-features-2021-07", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-features-2021-07", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named Operation -- properties.display.$ref: undefined => "#/components/schemas/schemas:166" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named Operation-display -- properties.provider.description: undefined => "Service provider: Microsoft.Resources", properties.description: undefined => "$ref":"#/components/schemas/schemas:170", "description":"Description of the operation." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named OperationListResult -- properties.value.$ref: undefined => "#/components/schemas/schemas:172", properties.value.description: undefined => "List of Microsoft.Resources operations." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named ErrorResponse -- properties.error: "$ref":"#/components/schemas/schemas:161", "description":"The error details." =>, properties.code: undefined => "$ref":"#/components/schemas/schemas:539", "description":"The error code.", "readOnly":true, properties.message: undefined => "$ref":"#/components/schemas/schemas:540", "description":"The error message.", "readOnly":true, properties.target: undefined => "$ref":"#/components/schemas/schemas:541", "description":"The error target.", "readOnly":true, properties.details: undefined => "$ref":"#/components/schemas/schemas:542", "description":"The error details.", "readOnly":true, properties.additionalInfo: undefined => "$ref":"#/components/schemas/schemas:543", "description":"The error additional info.", "readOnly":true, title: undefined => "Error Response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Error: Plugin prechecker reported failure." |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-policy-2020-09", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-policy-2020-09", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-preview-2020-08", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"resources/resource-manager/readme.md", "tag":"package-preview-2020-08", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
"subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
"providerNamespace": "subscriptionFeatureRegistrationGroupTestRG", | ||
"featureName": "testFeature", | ||
"api-version": "2020-09-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diwudd and @ifeoluwaokunoren - Please update the API version in all the example files to new api version 2021-07-01?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise changes LGTM. I will signoff once you update the api version in all example files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArcturusZhang @msyyc , can you have a look at the potential SDK breaking change ? |
For python, the breaking change is caused by previous PR, not this one. |
@diwudd , is this PR ready to merge? |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.