Skip to content

Conversation

openapi-sdkautomation[bot]
Copy link

Create to sync Azure/azure-rest-api-specs#14736

Installation Instructions

You can install the package @azure/arm-managedapplications of this PR using the following command:

curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14736/azure-sdk-for-js/@azure_arm-managedapplications/azure-arm-managedapplications-1.0.2.tgz" -o azure-arm-managedapplications-1.0.2.tgz
npm install azure-arm-managedapplications-1.0.2.tgz

Direct Download

The generated package can be directly downloaded from here:

@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14736/@azure_arm-managedapplications branch 6 times, most recently from 12a8491 to c675de9 Compare June 11, 2021 19:47
praveenkuttappan and others added 17 commits June 18, 2021 14:27
* Always use x-ms-date for Hmac

* Try to fix phone number tests

* Still another error in phone number tests

* Update phoneNumber session records

* Update phone numbers node sessions

* Manually fix node record sessions for phone numbers

* Update missed session files

Co-authored-by: JP Chen <[email protected]>
This PR makes three changes to our deployment template:

- Add networkAcls to the Managed HSM properties
- Remove the 60 second sleep after activation
- Speed up challenge auth tests for KV Keys by using methods that don't require creating and deleting keys.

The first is now needed, and without it deployment will fail.
The second is no longer needed, since it looks like the az cli appropriately waits before coming back.
Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.
## What

- Bump @opentelemetry/api to 0.20.0 in @azure/core-tracing
- Move all packages that are on core-http to the next core-tracing version 
- Remove version collision check from the tracer cache

## Why

This is part of our effort to move everyone to OTel 0.20.0 - but we have to stage it due to a transitive dependency and a 
breaking change in OTel. This PR updates core-tracing to use the latest OTel, fixes any breaking changes, and moves 
packages that we can move to the latest version of core-tracing.

Once core-rest-pipeline 1.1.0 is GA'd we'll be able to move the rest of the packages over to the latest core-tracing as well.

Removing the version collision came out of an offline discussion after these changes were reviewed - since it's a common 
source of pain and hasn't added much benefit (tracer conflicts incompatibility was never a problem) we decided to remove 
that logic and always grab a unique symbol per OT compatibility. 

## Callouts

The packages that are already on core-v2 will _not_ be upgraded at this time - we'll coordinate that with the GA of core-rest-pipeline 1.1.0
…-persistence (Azure#15384)

* [identity] Remove machine-code-dependent codepaths (Azure#15024)

* [identityg Remove machine-code-dependent codepaths

* Linter fixes

* Disable broken perf test

* Added missing import back

* [identity] Add extension registration API and default credential stack

* [identity-native] Introducing identity-native

* [identity] Rework extension API.

* Remove identity native

* Identity-persistence module

* Adding identity-vscode module

* Updated rush configuration

* Moved identity perf back to linking local identity

* Symbolic refactor of extension system

* Renamed MsalCredentialOptions to CacheableCredentialOptions

* Use Symbol.for instead of hacking around SymbolConstructor

* Improved identity-vscode samples

* Use persistence by default if a persistence provider has been registered.

* Improved identity-persistence samples

* Rename to identity-cache-persistence

* Feedback from arch board for mainline identity package

* Rename CredentialPersistenceOptions, format and lint

* Revert sanitization of scopes.

* Regenerated API.md for mainline identity

* Add tests and finalize @azure/identity-cache-persistence

* Record tests for identity-cache-persistence

* Renamed sample files.

* Some changes for testing in identity

* Updated identity-vscode

* Remove async version of useIdentityExtension

* Added a couple of tests for default no-extension behavior

* Fixed tests in recorder

* Removed errant console.log

* Added basic tests of identity-vscode

* Fixed a couple of tests that have started caching correctly

* Added browser shim for extensions/consumer.ts

* Mock keytar using sinon in live/playback environments

* Disable persistence tests on node !== 12

* Addressed feedback in identity-cache-persistence

* Restore perf-test

* Removed sanitizeScopeUrl from recorder

* Update sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts

Co-authored-by: Jeff Fisher <[email protected]>

* Fix gitignores

* Feedback for identity-vscode

* Changelog entry for recorder changes.

* core-http -> core-auth

* setter methods instead of setter props

* Some changes to docs and keywords

* Fixed linter warning

* Switch persistence tests from 12 to 14.

* Make the tests even refuse to import msal-node-extensions on anything other than Node 14

* Reverted changes to recorder

* master -> main

* More master -> main

* [identity] Make the samples extract only part of the token data

Co-authored-by: Jeff Fisher <[email protected]>
* Changes to create artifact in package directory
… fixing flaky tests to be more reliable. (Azure#15761)

Making changes to simplify a flaky test (and hopefully make it more reliable).

The main issue with the 'handle interrupted detach' method was that it relied on too many moving parts to work reliably. We could just eternally loop like we'd expect customers to do, but in the end we have a very simple test we're trying to perform - we want to receive, and while we're in the process of draining, cause a detach and have it early exit and reject/resolve immediately rather than waiting for the timeout.

I reworked the test to make that simpler by just removing the unneeded connection.idle() and just calling directly into the onDetached method. Because it happens prior to rhea even seeing that we're draining we should reliably win that race each time. 

There were a couple of other things changed for this PR as well:
- The max time per test was lowered accidentally. Bringing it back what's been used as the standard time in other libraries
- Fixed a spot in receiveMessages() where, if the link had been closed, we'd falsly return an empty array instead of throwing an exception indicating the link closed. This didn't appear to be related to the bug but it's incorrect and can hide bugs so I'd rather just throw the error than eat the condition and return an empty array. It's rare, but when it does happen the empty array response isn't right either - we're probably in the middle of a connection reset/change event.

Fixes Azure#13461
* Update links with master to use main

* Update ci.yml files

Co-authored-by: Chidozie Ononiwu <[email protected]>
* Update pipeline generation tool version

Consume latest changes from pipeline generation tool in Azure/azure-sdk-tools#1708

* Update tool version to include fix for public ci

Co-authored-by: Wes Haggard <[email protected]>
…ll anymore (Azure#15783)

I’ve got some customers writing to me directly with some confusion regarding getToken returning null. We’ve got some remnants of this type, but at this point, Identity doesn’t return null (except for ClientSecretCredential in the browser, which is generally unusable outside of our tests). This PR is to update these docs and to give a bit of clarity on what errors we’re throwing.
…ure#15883)

Now that `@opentelemetry/api` GA'd at [1.0.0](https://www.npmjs.com/package/@opentelemetry/api) we can bump our 
own dependency to `@opentelemetry/[email protected]`

Reminder: not _all_ packages are on the latest @opentelemetry/api... those that depend on @azure/core-rest-pipeline 
cannot be upgraded yet.
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14736/@azure_arm-managedapplications branch from c675de9 to bb66281 Compare June 22, 2021 22:43
chidozieononiwu and others added 5 commits June 22, 2021 15:51
This should allow our pipelines to pick these packages up for publication.
I recently added a few breaking changes to core-tracing which have impacted core-http but forgot to add changelog entries. This commit just addresses the changelog.
jeremymeng and others added 2 commits June 22, 2021 17:08
…5777)

and re-generate code.

* Don't set userAgentPrefix in convenience layer

* Update version constant prefix

* Use latest @autorest/typescript plugin
Merge 2290fefedc09ebcef566a51b9bfc99e3ece13257 into f7535f8211b7fe9a8d5e5ebdc09830677b55285c
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14736/@azure_arm-managedapplications branch from bb66281 to 2e05c13 Compare June 23, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.