Skip to content

Task 15001443: Remove identity field from the ActionGroup swagger as it had wrong type, and it is unused #19823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 26, 2022
Merged

Task 15001443: Remove identity field from the ActionGroup swagger as it had wrong type, and it is unused #19823

merged 8 commits into from
Jul 26, 2022

Conversation

thomasp98296
Copy link
Member

@thomasp98296 thomasp98296 commented Jul 19, 2022 •
edited
Loading

…urceId

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @thomasp98296 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 19, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 40 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    actionGroups_API.json 2019-03-01(5b1902d) 2019-03-01(main)
    actionGroups_API.json 2019-06-01(5b1902d) 2019-06-01(main)
    actionGroups_API.json 2021-09-01(5b1902d) 2021-09-01(main)
    actionGroups_API.json 2022-04-01(5b1902d) 2022-04-01(main)
    actionGroups_API.json 2022-06-01(5b1902d) 2022-06-01(main)

    Only 16 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L253:11
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
    New: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L383:7
    Old: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L393:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L383:7
    Old: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L393:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
    New: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L339:7
    Old: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L339:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L339:7
    Old: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L339:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
    New: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L383:7
    Old: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L393:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L383:7
    Old: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L393:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
    New: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L339:7
    Old: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L339:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L339:7
    Old: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L339:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'kind' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L757:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L581:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L757:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L581:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'Context' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L673:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L497:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'State' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L673:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L497:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'CompletedTime' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L673:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L497:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'CreatedTime' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L673:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L497:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ActionDetails' renamed or removed?
    New: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L673:7
    Old: Microsoft.Insights/stable/2021-09-01/actionGroups_API.json#L497:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌LintDiff: 2 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ AutoRest exception "location":"specification/monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"swagger-document/compose - FAILED"
    ❌ AutoRest exception "location":"specification/monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Error: '$.definitions.Resource.properties.tags.description' has incompatible values (--->- Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters.,
    ---Resource tags)."
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-2022-10
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️❌SDK Track2 Validation: 30 Errors, 0 Warnings failed [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-10">monitor/resource-manager/readme.md#package-2022-10
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-06">monitor/resource-manager/readme.md#package-2022-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-06-01-only">monitor/resource-manager/readme.md#package-2022-06-01-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-04">monitor/resource-manager/readme.md#package-2022-04
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-04-01-only">monitor/resource-manager/readme.md#package-2022-04-01-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2021-05-preview-diagnostics">monitor/resource-manager/readme.md#package-2021-05-preview-diagnostics
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2022-02">monitor/resource-manager/readme.md#package-2022-02
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2021-09">monitor/resource-manager/readme.md#package-2021-09
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2021-09-01-only">monitor/resource-manager/readme.md#package-2021-09-01-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2021-07">monitor/resource-manager/readme.md#package-2021-07
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2021-04">monitor/resource-manager/readme.md#package-2021-04
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2020-03">monitor/resource-manager/readme.md#package-2020-03
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2019-11">monitor/resource-manager/readme.md#package-2019-11
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2019-06">monitor/resource-manager/readme.md#package-2019-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2019-03">monitor/resource-manager/readme.md#package-2019-03
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2019-06-01-only">monitor/resource-manager/readme.md#package-2019-06-01-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/5b1902de585f17781ee08b8c9a529b138cf37f74/specification/monitor/resource-manager/readme.md#tag-package-2019-03-01-only">monitor/resource-manager/readme.md#package-2019-03-01-only
    The following errors/warnings are introduced by current PR:

    Only 16 items are listed, please refer to log for more details.

    Rule Message
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true,
    "description":"The system metadata related to the response.",
    "$ref":"#/components/schemas/schemas:1086" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Duplicate Schema named 'Resource' (4 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true,
    "description":"The system metadata related to the response.",
    "$ref":"#/components/schemas/schemas:1086" =>\n - properties.kind: => "$ref":"#/components/schemas/schemas:648",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:649",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:111" => "#/components/schemas/schemas:849"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:112" => "#/components/schemas/schemas:850"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:252" => "#/components/schemas/schemas:818"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service,
    the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:288",
    "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean",
    "default":true,
    "description":"Indicates whether this action group is enabled. If an action group is not enabled,
    then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:289",
    "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:290",
    "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:291",
    "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:292",
    "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:293",
    "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:294",
    "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:295",
    "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:296",
    "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:297",
    "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:298",
    "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:299",
    "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:841",
    "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:842",
    "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:628",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:629",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:829"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:830"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:232" => "#/components/schemas/schemas:798"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service,
    the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:268",
    "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean",
    "default":true,
    "description":"Indicates whether this action group is enabled. If an action group is not enabled,
    then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:269",
    "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:270",
    "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:271",
    "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:272",
    "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:273",
    "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:274",
    "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:275",
    "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:276",
    "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:277",
    "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:278",
    "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:279",
    "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:821",
    "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:822",
    "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04",
    "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:627",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:628",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04",
    "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:828"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:829"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04",
    "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:232" => "#/components/schemas/schemas:797"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service,
    the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04",
    "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:268",
    "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean",
    "default":true,
    "description":"Indicates whether this action group is enabled. If an action group is not enabled,
    then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:269",
    "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:270",
    "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:271",
    "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:272",
    "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:273",
    "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:274",
    "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:275",
    "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:276",
    "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:277",
    "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:278",
    "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[],
    "$ref":"#/components/schemas/schemas:279",
    "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:820",
    "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:821",
    "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-02",
    "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:628",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:629",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-02",
    "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:829"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:830"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-02",
    "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:232" => "#/components/schemas/schemas:798"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service,
    the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."


    The following errors/warnings exist before current PR submission:

    Only 16 items are listed, please refer to log for more details.

    Rule Message
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-10",
    "details":"Error: 5 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Error: 4 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04",
    "details":"Error: 4 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-02",
    "details":"Error: 4 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-09",
    "details":"Error: 4 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Error: 4 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-04",
    "details":"Error: 1 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"Error: 1 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Error: 1 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"Error: 1 errors occured -- cannot continue."
    ❌ "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-03",
    "details":"Error: 1 errors occured -- cannot continue."
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-06-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2022-04-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-05-preview-diagnostics",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-09-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-06-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 19, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - armmonitor - Approved - 0.8.0
    +	Field `Identity` of struct `ActionGroupResource` has been removed
+	Field `Identity` of struct `AzureResource` has been removed
+	Field `Kind` of struct `ActionGroupResource` has been removed
+	Field `Kind` of struct `AzureResource` has been removed
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-monitor - Approved - 3.1.0
    +	Model ActionGroupResource no longer has parameter identity
+	Model ActionGroupResource no longer has parameter kind
+	Model AzureResource no longer has parameter identity
+	Model AzureResource no longer has parameter kind
    ❌azure-sdk-for-js - @azure/arm-monitor - Approved - 8.0.0-beta.2
    +	Interface AzureResource no longer has parameter identity
+	Interface AzureResource no longer has parameter kind
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from 37966a6. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.ResourceManager.Monitor
cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • ❌Azure.ResourceManager.Monitor [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 37966a6. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ActionGroupsOperations.begin_create_notifications_at_action_group_resource_level
info	[Changelog]   - Added operation ActionGroupsOperations.begin_create_notifications_at_resource_group_level
info	[Changelog]   - Added operation ActionGroupsOperations.get_test_notifications_at_action_group_resource_level
info	[Changelog]   - Added operation ActionGroupsOperations.get_test_notifications_at_resource_group_level
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ActionGroupResource no longer has parameter identity
info	[Changelog]   - Model ActionGroupResource no longer has parameter kind
info	[Changelog]   - Model AzureResource no longer has parameter identity
info	[Changelog]   - Model AzureResource no longer has parameter kind
info	[Changelog]   - Removed operation group BaselineOperations
info	[Changelog]   - Removed operation group MetricBaselineOperations
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 37966a6. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmonitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*DataCollectionEndpointsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionEndpointsClientCreateOptions)` to `(context.Context, string, string, DataCollectionEndpointResource, *DataCollectionEndpointsClientCreateOptions)`
info	[Changelog] - Function `*DataCollectionRulesClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRulesClientCreateOptions)` to `(context.Context, string, string, DataCollectionRuleResource, *DataCollectionRulesClientCreateOptions)`
info	[Changelog] - Function `*DataCollectionEndpointsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionEndpointsClientUpdateOptions)` to `(context.Context, string, string, ResourceForUpdate, *DataCollectionEndpointsClientUpdateOptions)`
info	[Changelog] - Function `*DataCollectionRulesClient.Update` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRulesClientUpdateOptions)` to `(context.Context, string, string, ResourceForUpdate, *DataCollectionRulesClientUpdateOptions)`
info	[Changelog] - Function `*DataCollectionRuleAssociationsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRuleAssociationsClientCreateOptions)` to `(context.Context, string, string, DataCollectionRuleAssociationProxyOnlyResource, *DataCollectionRuleAssociationsClientCreateOptions)`
info	[Changelog] - Field `Body` of struct `DataCollectionRulesClientCreateOptions` has been removed
info	[Changelog] - Field `Body` of struct `DataCollectionRulesClientUpdateOptions` has been removed
info	[Changelog] - Field `Body` of struct `DataCollectionEndpointsClientUpdateOptions` has been removed
info	[Changelog] - Field `Body` of struct `DataCollectionEndpointsClientCreateOptions` has been removed
info	[Changelog] - Field `Identity` of struct `AzureResource` has been removed
info	[Changelog] - Field `Kind` of struct `AzureResource` has been removed
info	[Changelog] - Field `Body` of struct `DataCollectionRuleAssociationsClientCreateOptions` has been removed
info	[Changelog] - Field `Identity` of struct `ActionGroupResource` has been removed
info	[Changelog] - Field `Kind` of struct `ActionGroupResource` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeForecastOnly`
info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeEnabled`
info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeDisabled`
info	[Changelog] - New function `PossiblePredictiveAutoscalePolicyScaleModeValues() []PredictiveAutoscalePolicyScaleMode`
info	[Changelog] - New function `*PredictiveMetricClient.Get(context.Context, string, string, string, string, string, string, string, *PredictiveMetricClientGetOptions) (PredictiveMetricClientGetResponse, error)`
info	[Changelog] - New function `NewPredictiveMetricClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PredictiveMetricClient, error)`
info	[Changelog] - New struct `AutoscaleErrorResponse`
info	[Changelog] - New struct `AutoscaleErrorResponseError`
info	[Changelog] - New struct `PredictiveAutoscalePolicy`
info	[Changelog] - New struct `PredictiveMetricClient`
info	[Changelog] - New struct `PredictiveMetricClientGetOptions`
info	[Changelog] - New struct `PredictiveMetricClientGetResponse`
info	[Changelog] - New struct `PredictiveResponse`
info	[Changelog] - New struct `PredictiveValue`
info	[Changelog] - New struct `ResourceAutoGenerated`
info	[Changelog] - New struct `ResourceAutoGenerated2`
info	[Changelog] - New struct `ResourceAutoGenerated3`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientPostTestNotificationsResponse`
info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientCreateNotificationsAtResourceGroupLevelResponse`
info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientCreateNotificationsAtActionGroupResourceLevelResponse`
info	[Changelog] - New field `PredictiveAutoscalePolicy` in struct `AutoscaleSetting`
info	[Changelog] - New field `SystemData` in struct `AutoscaleSettingResource`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 34 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 37966a6. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group PredictiveMetric
info	[Changelog]   - Added operation ActionGroups.beginCreateNotificationsAtActionGroupResourceLevel
info	[Changelog]   - Added operation ActionGroups.beginCreateNotificationsAtActionGroupResourceLevelAndWait
info	[Changelog]   - Added operation ActionGroups.beginCreateNotificationsAtResourceGroupLevel
info	[Changelog]   - Added operation ActionGroups.beginCreateNotificationsAtResourceGroupLevelAndWait
info	[Changelog]   - Added operation ActionGroups.getTestNotificationsAtActionGroupResourceLevel
info	[Changelog]   - Added operation ActionGroups.getTestNotificationsAtResourceGroupLevel
info	[Changelog]   - Added operation DataCollectionRuleAssociations.listByDataCollectionEndpoint
info	[Changelog]   - Added Interface ActionGroup
info	[Changelog]   - Added Interface ActionGroupsCreateNotificationsAtActionGroupResourceLevelHeaders
info	[Changelog]   - Added Interface ActionGroupsCreateNotificationsAtActionGroupResourceLevelOptionalParams
info	[Changelog]   - Added Interface ActionGroupsCreateNotificationsAtResourceGroupLevelHeaders
info	[Changelog]   - Added Interface ActionGroupsCreateNotificationsAtResourceGroupLevelOptionalParams
info	[Changelog]   - Added Interface ActionGroupsGetTestNotificationsAtActionGroupResourceLevelOptionalParams
info	[Changelog]   - Added Interface ActionGroupsGetTestNotificationsAtResourceGroupLevelOptionalParams
info	[Changelog]   - Added Interface ActionGroupsPostTestNotificationsHeaders
info	[Changelog]   - Added Interface ActionList
info	[Changelog]   - Added Interface ActivityLogAlertsListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface ActivityLogAlertsListBySubscriptionIdNextOptionalParams
info	[Changelog]   - Added Interface AlertRuleAllOfCondition
info	[Changelog]   - Added Interface AlertRuleLeafCondition
info	[Changelog]   - Added Interface AlertRuleList
info	[Changelog]   - Added Interface AlertRulePatchObject
info	[Changelog]   - Added Interface AutoscaleErrorResponse
info	[Changelog]   - Added Interface AutoscaleErrorResponseError
info	[Changelog]   - Added Interface AzureResourceAutoGenerated
info	[Changelog]   - Added Interface ColumnDefinition
info	[Changelog]   - Added Interface DataCollectionRuleAssociationsListByDataCollectionEndpointNextOptionalParams
info	[Changelog]   - Added Interface DataCollectionRuleAssociationsListByDataCollectionEndpointOptionalParams
info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
info	[Changelog]   - Added Interface IisLogsDataSource
info	[Changelog]   - Added Interface LogFilesDataSource
info	[Changelog]   - Added Interface LogFileSettings
info	[Changelog]   - Added Interface LogFileTextSettings
info	[Changelog]   - Added Interface Metadata
info	[Changelog]   - Added Interface PredictiveAutoscalePolicy
info	[Changelog]   - Added Interface PredictiveMetricGetOptionalParams
info	[Changelog]   - Added Interface PredictiveResponse
info	[Changelog]   - Added Interface PredictiveValue
info	[Changelog]   - Added Interface ResourceAutoGenerated2
info	[Changelog]   - Added Interface ResourceAutoGenerated3
info	[Changelog]   - Added Interface ResourceAutoGenerated4
info	[Changelog]   - Added Interface StreamDeclaration
info	[Changelog]   - Added Type Alias ActionGroupsCreateNotificationsAtActionGroupResourceLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsCreateNotificationsAtResourceGroupLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsGetTestNotificationsAtActionGroupResourceLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsGetTestNotificationsAtResourceGroupLevelResponse
info	[Changelog]   - Added Type Alias ActivityLogAlertsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ActivityLogAlertsListBySubscriptionIdNextResponse
info	[Changelog]   - Added Type Alias AlertRuleAnyOfOrLeafCondition
info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationMetadata
info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointNextResponse
info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointResponse
info	[Changelog]   - Added Type Alias DataCollectionRuleMetadata
info	[Changelog]   - Added Type Alias KnownColumnDefinitionType
info	[Changelog]   - Added Type Alias KnownLogFilesDataSourceFormat
info	[Changelog]   - Added Type Alias KnownLogFileTextSettingsRecordStartTimestampFormat
info	[Changelog]   - Added Type Alias LogFilesDataSourceSettings
info	[Changelog]   - Added Type Alias LogFileSettingsText
info	[Changelog]   - Added Type Alias PredictiveAutoscalePolicyScaleMode
info	[Changelog]   - Added Type Alias PredictiveMetricGetResponse
info	[Changelog]   - Interface AutoscaleSettingResourcePatch has a new optional parameter predictiveAutoscalePolicy
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataCollectionRuleAssociation has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleAssociationProxyOnlyResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataFlow has a new optional parameter outputStream
info	[Changelog]   - Interface DataFlow has a new optional parameter transformKql
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter iisLogs
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter logFiles
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Class MonitorClient has a new parameter predictiveMetric
info	[Changelog]   - Add parameters of AzureResourceAutoGenerated to TypeAlias ActivityLogAlertResource
info	[Changelog]   - Add parameters of ResourceAutoGenerated to TypeAlias AlertRuleResource
info	[Changelog]   - Add parameters of ResourceAutoGenerated2 to TypeAlias LogProfileResource
info	[Changelog]   - Add parameters of ResourceAutoGenerated4 to TypeAlias LogSearchRuleResource
info	[Changelog]   - Add parameters of ResourceAutoGenerated3 to TypeAlias MetricAlertResource
info	[Changelog]   - Type Alias AutoscaleSettingResource has a new parameter predictiveAutoscalePolicy
info	[Changelog]   - Added Enum KnownKnownColumnDefinitionType
info	[Changelog]   - Added Enum KnownKnownLogFilesDataSourceFormat
info	[Changelog]   - Added Enum KnownKnownLogFileTextSettingsRecordStartTimestampFormat
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation ActivityLogAlerts.update has a new signature
info	[Changelog]   - Interface AzureResource no longer has parameter identity
info	[Changelog]   - Interface AzureResource no longer has parameter kind
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter etag
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter kind
info	[Changelog]   - Delete parameters of Resource in TypeAlias ActivityLogAlertResource
info	[Changelog]   - Delete parameters of Resource in TypeAlias AlertRuleResource
info	[Changelog]   - Delete parameters of Resource in TypeAlias LogProfileResource
info	[Changelog]   - Delete parameters of ResourceAutoGenerated in TypeAlias LogSearchRuleResource
info	[Changelog]   - Delete parameters of Resource in TypeAlias MetricAlertResource
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 37966a6. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️monitor [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 37966a6. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.monitor [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @thomasp98296, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Jul 19, 2022
    Closed
    This was referenced Jul 19, 2022
    Closed
    Closed
    This was referenced Jul 19, 2022
    Closed
    Closed
    Closed
    @thomasp98296 thomasp98296 changed the title Task 15001443: Bug 14937463: Should throw a bad request with bad reso… Task 15001443: Remove identity field from the ActionGroup swagger as it had wrong type, and it is unused Jul 19, 2022
    @openapi-workflow-bot
    Copy link

    Hi @thomasp98296, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Thomas Pham added 3 commits July 19, 2022 01:00
    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @azure-sdk azure-sdk mentioned this pull request Jul 21, 2022
    Closed
    @ArcturusZhang
    Copy link
    Member

    I am OK with the changes in this PR. We just need the breaking change approved since we are

    1. removing properties
    2. adding new APIs in the same api-version.
      Both these changes need the approval from the breaking change review board.

    @ArcturusZhang
    Copy link
    Member

    I will ask the corresponding SDK owners' approval once we have approval from the breaking change review board

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 25, 2022
    @ArcturusZhang
    Copy link
    Member

    suppress the lintdiff issues since it is failing because of the modeler v1 issue on model collisions

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 26, 2022
    @ArcturusZhang ArcturusZhang merged commit 37966a6 into Azure:main Jul 26, 2022
    This was referenced Jul 26, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @thomasp98296 @ArcturusZhang @tadelesh @JeffreyRichter @raych1 @qiaozha @msyyc