Skip to content

Task 15001443: Remove identity field from the ActionGroup swagger as it had wrong type, and it is unused #19823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Task 15001443: Remove identity field from the ActionGroup swagger as it had wrong type, and it is unused #19823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4cfc489
Task 15001443: Bug 14937463: Should throw a bad request with bad reso…
Jul 19, 2022
dc7c0ed
Revert "Task 15001443: Bug 14937463: Should throw a bad request with …
Jul 19, 2022
c19892d
Remove unused property
Jul 19, 2022
b5ef90d
Revert
Jul 19, 2022
aae3b7e
Revert "Revert"
Jul 19, 2022
00fa541
Remove outdated api
Jul 19, 2022
1c57a5e
Also remove kind
Jul 21, 2022
5b1902d
Remove kind
Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/actionGroups_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,16 +352,6 @@
"readOnly": true,
"description": "Azure resource type"
},
"kind": {
"type": "string",
"readOnly": true,
"description": "Azure resource kind"
},
"identity": {
"type": "string",
"readOnly": true,
"description": "Azure resource identity"
},
"location": {
"type": "string",
"description": "Resource location",
Expand Down
10 changes: 0 additions & 10 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,16 +352,6 @@
"readOnly": true,
"description": "Azure resource type"
},
"kind": {
"type": "string",
"readOnly": true,
"description": "Azure resource kind"
},
"identity": {
"type": "string",
"readOnly": true,
"description": "Azure resource identity"
},
"location": {
"type": "string",
"description": "Resource location",
Expand Down
274 changes: 225 additions & 49 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2021-09-01/actionGroups_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
"description": "Send test notifications to a set of provided receivers",
"operationId": "ActionGroups_PostTestNotifications",
"x-ms-examples": {
"List action groups": {
"Create notifications at subscription level": {
"$ref": "./examples/postTestNotifications.json"
}
},
Expand All @@ -242,9 +242,137 @@
],
"responses": {
"202": {
"description": "The notification request accepted",
"headers": {
"location": {
"type": "string",
"description": "The location header that has the polling uri."
}
}
},
"200": {
"description": "The notification succeeded",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/createNotifications": {
"post": {
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"description": "Send test notifications to a set of provided receivers",
"operationId": "ActionGroups_CreateNotificationsAtResourceGroupLevel",
"x-ms-examples": {
"Create notifications at resource group level": {
"$ref": "./examples/postTestNotificationsAtResourceGroupLevel.json"
}
},
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
},
{
"name": "notificationRequest",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/NotificationRequestBody"
},
"description": "The notification request body which includes the contact details"
}
],
"responses": {
"202": {
"description": "The notification request accepted",
"headers": {
"location": {
"type": "string",
"description": "The location header that has the polling uri."
}
}
},
"200": {
"description": "The notification succeeded",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/actionGroups/{actionGroupName}/createNotifications": {
"post": {
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"description": "Send test notifications to a set of provided receivers",
"operationId": "ActionGroups_CreateNotificationsAtActionGroupResourceLevel",
"x-ms-examples": {
"Create notifications at resource group level": {
"$ref": "./examples/postTestNotificationsAtActionGroupResourceLevel.json"
}
},
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ActionGroupNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
},
{
"name": "notificationRequest",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/NotificationRequestBody"
},
"description": "The notification request body which includes the contact details"
}
],
"responses": {
"202": {
"description": "The notification request accepted",
"headers": {
"location": {
"type": "string",
"description": "The location header that has the polling uri."
}
}
},
"200": {
"description": "The notification succeeded",
"schema": {
"$ref": "#/definitions/TestNotificationResponse"
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
Expand All @@ -261,7 +389,7 @@
"description": "Get the test notifications by the notification id",
"operationId": "ActionGroups_GetTestNotifications",
"x-ms-examples": {
"Get notification details": {
"Get notification details at subscription level": {
"$ref": "./examples/getTestNotifications.json"
}
},
Expand Down Expand Up @@ -292,12 +420,93 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/notificationStatus/{notificationId}": {
"get": {
"description": "Get the test notifications by the notification id",
"operationId": "ActionGroups_GetTestNotificationsAtResourceGroupLevel",
"x-ms-examples": {
"Get notification details at resource group level": {
"$ref": "./examples/getTestNotificationsAtResourceGroupLevel.json"
}
},
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/NotificationIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "The notification details",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/actionGroups/{actionGroupName}/notificationStatus/{notificationId}": {
"get": {
"description": "Get the test notifications by the notification id",
"operationId": "ActionGroups_GetTestNotificationsAtActionGroupResourceLevel",
"x-ms-examples": {
"Get notification details at resource group level": {
"$ref": "./examples/getTestNotificationsAtActionGroupResourceLevel.json"
}
},
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/ActionGroupNameParameter"
},
{
"$ref": "#/parameters/NotificationIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "The notification details",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Insights/actionGroups": {
"get": {
"description": "Get a list of all action groups in a subscription.",
"operationId": "ActionGroups_ListBySubscriptionId",
"x-ms-examples": {
"List action groups": {
"List action groups at subscription level": {
"$ref": "./examples/listActionGroups.json"
}
},
Expand Down Expand Up @@ -333,7 +542,7 @@
"description": "Get a list of all action groups in a resource group.",
"operationId": "ActionGroups_ListByResourceGroup",
"x-ms-examples": {
"List action groups": {
"List action groups at resource group level": {
"$ref": "./examples/listActionGroups.json"
}
},
Expand Down Expand Up @@ -435,16 +644,6 @@
"readOnly": true,
"description": "Azure resource type"
},
"kind": {
"type": "string",
"readOnly": true,
"description": "Azure resource kind"
},
"identity": {
"type": "string",
"readOnly": true,
"description": "Azure resource identity"
},
"location": {
"type": "string",
"description": "Resource location",
Expand All @@ -468,62 +667,39 @@
"x-ms-azure-resource": true,
"description": "An azure resource object"
},
"TestNotificationResponse": {
"description": "The response when test notification succeeded",
"type": "object",
"properties": {
"notificationId": {
"type": "string",
"description": "The notification id"
},
"correlationId": {
"type": "string",
"description": "The correlation id"
},
"createdTime": {
"type": "string",
"description": "The created time"
}
},
"required": [
"notificationId",
"correlationId",
"createdTime"
]
},
"TestNotificationDetailsResponse": {
"description": "The details of the test notification results.",
"type": "object",
"properties": {
"Context": {
"context": {
"type": "object",
"$ref": "#/definitions/Context"
},
"State": {
"state": {
"type": "string",
"description": "The overall state"
},
"CompletedTime": {
"completedTime": {
"type": "string",
"description": "The completed time"
},
"CreatedTime": {
"createdTime": {
"type": "string",
"description": "The created time"
},
"ActionDetails": {
"actionDetails": {
"x-ms-identifiers": [
"name"
],
"type": "array",
"items": {
"$ref": "#/definitions/ActionDetail"
},
"x-ms-identifiers": [
"Name"
],
"description": "The list of action detail"
}
},
"required": [
"State"
"state"
]
},
"ActionDetail": {
Expand Down Expand Up @@ -560,11 +736,11 @@
"description": "The context info",
"type": "object",
"properties": {
"NotificationSource": {
"notificationSource": {
"type": "string",
"description": "The source of the notification request"
},
"ContextType": {
"contextType": {
"type": "string",
"description": "The context id type"
}
Expand Down
Loading