-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Downgraded the version of ManagedInstances to generate .Net SDK for sql/resource manager #29316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yGroups Api due to .Net Sdk build failures caused by error : MembersMustExist in these API's
…1 as having build erros while building .net sdk with error 'implementation but it does exist in the contract.'
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v2.2.2) | new version | base version |
---|---|---|
default | default(08a92a0) | default(main) |
️❌
Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/managedInstances/{}/refreshExternalGovernanceStatus is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json |
The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
This was referenced Jun 4, 2024
It's a PR for Control Plane (ARM) API, not sure why i'am not able to update the template. |
ericshape
approved these changes
Jun 4, 2024
/pr RequestMerge |
Please wait for the ARM review to get over and request a merge after you see an ARMSignedOff label against the PR |
since i'am unable to modify the description above, posting the link to my previous similar PR #28976 , which had similar changes |
rkmanda
approved these changes
Jun 9, 2024
/pr RequestMerge |
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 11, 2024
…ql/resource manager (Azure#29316) * Downgraded the version of ManagedInstances and DistributedAvailabilityGroups Api due to .Net Sdk build failures caused by error : MembersMustExist in these API's * restored the version of ManagedInstance Api as previous * Update the version of ManagedInstance APi to previous version 22-08-01 as having build erros while building .net sdk with error 'implementation but it does exist in the contract.' --------- Co-authored-by: Ji Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.