Skip to content

Fail the 'generate sdk' step when 'npm ci' fails #39453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raych1 merged 7 commits into from
Jan 7, 2026
Merged

Fail the 'generate sdk' step when 'npm ci' fails #39453

raych1 merged 7 commits into from
Jan 7, 2026

Conversation

@raych1
Copy link
Member

@raych1 raych1 commented Jan 5, 2026 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jan 5, 2026 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

raych1
raych1 commented Jan 5, 2026
View reviewed changes
@raych1 raych1 self-assigned this Jan 5, 2026
@raych1 raych1 moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 Jan 5, 2026
mikeharder
mikeharder reviewed Jan 5, 2026
View reviewed changes
mikeharder
mikeharder requested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of checking for specific errors, you should configure bash to fail on any error. Something like this at the top of the script.

set -euo pipefail

@github-actions github-actions bot added ARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/widget/armwidget
Python azure-mgmt-widget
JavaScript @azure/arm-widget
Java com.azure.resourcemanager:azure-resourcemanager-widget

@github-actions github-actions bot removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required resource-manager ARMReview TypeSpec Authored with TypeSpec labels Jan 7, 2026
@github-actions github-actions bot removed the RPaaS label Jan 7, 2026
@raych1 raych1 merged commit 368962e into main Jan 7, 2026
42 of 44 checks passed
@raych1 raych1 deleted the users/raych1/fail-check branch January 7, 2026 17:11
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

@mikeharder mikeharder mikeharder approved these changes

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@raych1 raych1

Labels

None yet

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate SDK step should fail when 'npm ci' fails

4 participants

@raych1 @weshaggard @mikeharder