Skip to content

Fail the 'generate sdk' step when 'npm ci' fails #39453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 7 commits into from
Jan 7, 2026
Merged

Fail the 'generate sdk' step when 'npm ci' fails #39453

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2561385
Fail the step when npm ci fails
raych1 Jan 5, 2026
0f49ff0
test npm ci failure
raych1 Jan 5, 2026
eb3b15d
Reverted test change
raych1 Jan 5, 2026
3998ed9
exit bash globally in case of error
raych1 Jan 7, 2026
826d575
test change
raych1 Jan 7, 2026
c6953af
test sample spec
raych1 Jan 7, 2026
46fa057
Reverted sample spec change
raych1 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
parameters:
- name: SpecRepoUrl
type: string
Expand Down Expand Up @@ -246,6 +246,10 @@
cd $(SpecRepoDirectory)
echo "##[group]Run npm ci"
npm ci
if [ "$?" -ne 0 ]; then
echo "##vso[task.logissue type=error]npm ci failed."
exit 1
fi
echo "##[endgroup]"
node $(SpecRepoDirectory)/eng/tools/spec-gen-sdk-runner/cmd/spec-gen-sdk-runner.js \
--scp $(SpecRepoDirectory) \
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "azure-rest-api-specs",
"devDependencies": {
"@azure-tools/spec-gen-sdk": "~0.9.1",
"@azure-tools/spec-gen-sdk1": "~0.9.1",
"@azure-tools/specs-shared": "file:.github/shared",
"@azure-tools/typespec-apiview": "0.7.2",
"@azure-tools/typespec-autorest": "0.63.0",
Expand Down
Loading