mgmt containerinstance , fix live test failures #47634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added @disabled annotation to testBeginCreateWithFileShareVolume - Included reason for disabling: internal policy denies local auth methods - Preserved existing @DoNotRecord annotation and skipInPlayback setting
- Add storage account creation and key retrieval for file share testing - Integrate Azure file share volume configuration with existing storage credentials - Include ShareServiceClientBuilder for file endpoint management - Remove @disabled annotation to activate file share volume tests - Add storage manager initialization in test base class - Update container group volume definition to use existing Azure file share
…ions with managed identity
…rations - Added testBeginCreateWithEmptyDirectoryVolume method - Disabled testBeginCreateWithFileShareVolume due to internal policy restrictions - Updated volume configuration logic to use withEmptyDirectoryVolume instead of manual volume definition - Added proper annotations for test recording and policy compliance - Implemented container group creation with virtual network and volume mounting - Added assertions for volume count validation
…ence Removed outdated comment about Azure Storage SMB mounting with managed identity and updated the test documentation to reflect current behavior. The test now properly references the Azure documentation for container instances volume mounting.
Update the assets tag from a0e5cc2e29 to bd0493a9b7 in azure-resourcemanager-containerinstance module
…e tests - Removed storage account creation logic from ContainerGroupTest - Eliminated unused StorageManager dependency from ContainerInstanceManagementTest - Cleaned up related imports and fields that were no longer needed - Simplified test setup by removing unnecessary storage account initialization
Update the assets tag in assets.json from bd0493a9b7 to cade898991 for azure-resourcemanager-containerinstance package.
- Removed unused Azure identity imports (AzureAuthorityHosts, ClientSecretCredential, DefaultAzureCredentialBuilder) - Removed unused storage related imports (StorageAccount, StorageAccountKey, ShareServiceAsyncClient, ShareServiceClientBuilder)
v-huizhu2
requested review from
a team,
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
github-actions
bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes live test failures in the containerinstance management library caused by Azure policy restrictions on local authentication methods for Azure Storage file shares. The fix involves disabling the failing test and adding a replacement test that uses an empty directory volume instead.
- Disabled
testBeginCreateWithFileShareVolumetest due to Azure policy preventing local authentication methods - Added new
testBeginCreateWithEmptyDirectoryVolumetest to maintain test coverage for volume mounting functionality - Updated test recordings (assets.json)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ContainerGroupTest.java | Added @Disabled annotation to failing file share test with explanation, added new test for empty directory volume, and reordered imports alphabetically |
| assets.json | Updated test recording tag to include new test recordings |
...erinstance/src/test/java/com/azure/resourcemanager/containerinstance/ContainerGroupTest.java
Outdated
Show resolved
Hide resolved
…src/test/java/com/azure/resourcemanager/containerinstance/ContainerGroupTest.java Co-authored-by: Copilot <[email protected]>
XiaofeiCao
reviewed
Jan 6, 2026
...erinstance/src/test/java/com/azure/resourcemanager/containerinstance/ContainerGroupTest.java
Outdated
Show resolved
Hide resolved
…src/test/java/com/azure/resourcemanager/containerinstance/ContainerGroupTest.java Co-authored-by: Xiaofei Cao <[email protected]>
weidongxu-microsoft
approved these changes
Jan 8, 2026
XiaofeiCao
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request was denied due to internal policy. Local authentication methods are not allowed.
Add issues #47487
#47372
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines