[core-client-rest] downgrade dependency @azure/abort-controller to v1
#27948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for release as v2 hasn't been published yet.
jeremymeng
requested review from
deyaaeldeen,
joheredi and
xirzec
as code owners
deyaaeldeen
approved these changes
Nov 30, 2023
Member
|
Did we consider releasing the updated abort controller? or is it too soon? |
Member
Author
I prefer not rushing it out. |
Collaborator
|
API change check API changes are not detected in this pull request. |
timovv
approved these changes
Nov 30, 2023
Member
Author
|
Identity tests are passing on nodejs 21.2.0 #27951. Looks that NodeJS 21.3.0 has some changes that failed some identity tests on MacOS. Will follow up on that. Overriding this. |
Member
Author
|
/check-enforcer override |
jeremymeng
deleted the
core/client-rest-downgrade-abort-controller-dep
branch
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Dec 5, 2023
…ler` to v1 (Azure#27948)" This reverts commit badad46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
@azure-rest/core-clientrelease as v2 hasn't been published yet.