[EngSys] eng/tools/versioning/set-dev.js fixes #36084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
mikeharder,
weshaggard and
benbp
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues in the engineering system's versioning script and improves logging with indentation:
- Adds "utility" to the version policy check so utility packages get dev versions
- Changes version comparison logic from exact equality to range satisfaction using
semver.satisfies() - Improves logging by adding indentation through
logPrefixparameters for better readability
This PR addresses two issues: - we should set dev versions for utility packages too but currently don't because of a missing category in the version policy check. - we should use dev version of a package for its dependents if its current version satisfies their dependency version range requirements. Currently we use its dev version if its current version equals the minimum version of dependency version range requirements. While at this, logging is also improved by introducing indentations for nested log lines.
jeremymeng
force-pushed
the
engsys/set-dev-improve-logging
branch
from
79a3989 to
e38345a
Compare
jeremymeng
commented
Sep 30, 2025
| if (semver.eq(parsedDepMinVersion, parsedPackageVersion)) { | ||
| repoPackages = updatePackageVersion(repoPackages, depName, buildId, catalogs); | ||
| console.log(`${logPrefix}resolved version = ${resolvedVersion.resolution.specifier}`); | ||
| if (semver.satisfies(packageVersion, resolvedVersion.resolution.specifier)) { |
There was a problem hiding this comment.
Changing to use semver.satisfies
jeremymeng
commented
Sep 30, 2025
| const parsedDepMinVersion = semver.minVersion(depVersionRange); | ||
| if (semver.eq(parsedDepMinVersion, parsedPackageVersion)) { | ||
| repoPackages = updatePackageVersion(repoPackages, depName, buildId, catalogs); | ||
| if (semver.satisfies(packageVersion, depVersionRange)) { |
There was a problem hiding this comment.
Changing to use semver.satisfies
jeremymeng
commented
Sep 30, 2025
| if (resolvedVersion.type === "found") { | ||
| const parsedDepMinVersion = semver.minVersion(resolvedVersion.resolution.specifier); | ||
| shouldReplace = semver.eq(parsedDepMinVersion, parsedPackageVersion); | ||
| shouldReplace = semver.satisfies(packageVersion, resolvedVersion.resolution.specifier); |
There was a problem hiding this comment.
Changing to use semver.satisfies
jeremymeng
commented
Sep 30, 2025
| } else { | ||
| const parsedDepMinVersion = semver.minVersion(depVersionRange); | ||
| shouldReplace = semver.eq(parsedDepMinVersion, parsedPackageVersion); | ||
| shouldReplace = semver.satisfies(packageVersion, depVersionRange); |
There was a problem hiding this comment.
Changing to use semver.satisfies
jeremymeng
commented
Sep 30, 2025
| for (const pkg of Object.keys(repoPackages)) { | ||
| if ( | ||
| ["client", "core", "management"].includes(repoPackages[pkg].versionPolicy) && | ||
| ["client", "core", "management", "utility"].includes(repoPackages[pkg].versionPolicy) && |
There was a problem hiding this comment.
adding the missing utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
we should set dev versions for utility packages too but currently don't because of a missing category in the version policy check.
we should use dev version of a package for its dependents if its current version satisfies their dependency version range requirements. Currently we use its dev version if its current version equals the minimum version of dependency version range requirements.
While at this, logging is also improved by introduce indentations for nested log lines.